Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't discard the workspace pod when authz is misconfigured #740

Open
EronWright opened this issue Nov 1, 2024 · 1 comment
Open

Don't discard the workspace pod when authz is misconfigured #740

EronWright opened this issue Nov 1, 2024 · 1 comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@EronWright
Copy link
Contributor

The workspace controller terminates the workspace pod if the Install RPC method fails, to avoid leaving the pod in an undefined state. Unfortunately, this masks authz errors, because Install is the first call that is made. Usability would improve if the controller didn't discard the pod in that situation, accomplished either by special-casing the error handling or by calling the WhoAmI RPC method firstly.
@EronWright EronWright converted this from a draft issue Nov 1, 2024
@cleverguy25
Copy link

Added to epic #586

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 1, 2024
@cleverguy25 cleverguy25 mentioned this issue Nov 1, 2024
Closed
5 tasks
@EronWright EronWright added the impact/usability Something that impacts users' ability to use the product easily and intuitively label Nov 1, 2024
@EronWright EronWright mentioned this issue Nov 1, 2024
Open
@blampe blampe removed the needs-triage Needs attention from the triage team label Nov 11, 2024
@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
No open projects
Pulumi Kubernetes Operator v2
Status: No status
Milestone
No milestone
Development

No branches or pull requests
5 participants
@blampe @mikhailshilkov @EronWright @cleverguy25 @pulumi-bot