Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collection for Update objects #733

Open
EronWright opened this issue Oct 29, 2024 · 1 comment
Open

Garbage collection for Update objects #733

EronWright opened this issue Oct 29, 2024 · 1 comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@EronWright
Copy link
Contributor

EronWright commented Oct 29, 2024 •
edited
Loading

Update objects accumulate indefinitely in the system, and the operator should cleanup the old completed updates, e.g. after a week or so.

Should the Update controller handle the cleanup uniformly? Or should the Stack controller handle the cleanup for the updates that it owns? I would lean towards the former, by introducing a Update.spec.ttlSecondsAfterFinished field that the Stack controller may set and is implemented by the Update controller.

See https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/
@EronWright EronWright converted this from a draft issue Oct 29, 2024
@cleverguy25
Copy link

Added to epic #586

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 29, 2024
@cleverguy25 cleverguy25 mentioned this issue Oct 29, 2024
Closed
5 tasks
@EronWright EronWright added the good-first-issue Start here if you'd like to start contributing to Pulumi label Oct 29, 2024
@blampe blampe added kind/enhancement Improvements or new features impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Oct 29, 2024
@EronWright EronWright mentioned this issue Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
No open projects
Pulumi Kubernetes Operator v2
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blampe @EronWright @cleverguy25 @pulumi-bot