Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push flux events when using a flux source #573

Open
nicu-da opened this issue Apr 23, 2024 · 3 comments
Open

Push flux events when using a flux source #573

nicu-da opened this issue Apr 23, 2024 · 3 comments
Labels
area/flux Related to Flux integration kind/enhancement Improvements or new features

Comments

@nicu-da
Copy link

nicu-da commented Apr 23, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Unless I'm missing something, there is no easy way to get notifications for when a stack CR is being updated, it has failed, it started reconciling actual differences, it has finished reconciling and so on.

I would've expected this is included in the flux source integration, and that events are published from the stack controller.

Affected area/feature

Flux integration

@nicu-da nicu-da added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Apr 23, 2024
@blampe blampe removed the needs-triage Needs attention from the triage team label Apr 26, 2024
@blampe
Copy link
Contributor

blampe commented Apr 26, 2024

Hi @nicu-da, could you share a little more detail about what you'd like to see here?

The controller should already be emitting these events for the stack-controller. Are you seeing those?

Is the issue that you'd like the Flux notification-controller to more seamlessly pick these up? Or something else?

@blampe blampe added the area/flux Related to Flux integration label Apr 26, 2024
@nicu-da
Copy link
Author

nicu-da commented Apr 29, 2024

Hi @blampe

Thank you for the update. Indeed those events seem to be produced for the Stack but they are pure k8s events from what I can tell, and are missing the flux specific fields:

involvedObject the API version, kind, name and namespace of the Flux object
metadata.annotations the Flux specific metadata e.g. source revision
source.component the Flux controller name where the event originated from

The reasoning to have those fields present is that I expect that should allow for fluxcd alerts to be generated in this case, thus triggering slack notifications for stack events.
In the current form, only the creation of a new artifact from the flux source triggers an alert, thus is pretty useless in actually understanding if the reconciliation was successful without checking logs/the stack state.

The only way I can think of to get notified about stack events currently is using something like https://github.com/kubeshop/botkube, but that adds one more layer, but please correct me if I'm wrong and there's an easier way to get real time notifications around the stack events.

@cleverguy25
Copy link

Added to epic #586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flux Related to Flux integration kind/enhancement Improvements or new features
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants