From 6fbcd4cb30956d4c148c12d40183e8e1cef3233f Mon Sep 17 00:00:00 2001
From: Ramon Quitales <ramon@pulumi.com>
Date: Mon, 7 Oct 2024 10:15:16 -0700
Subject: [PATCH] [V2] Clean up utils file (#708)

### Proposed changes

This PR removes the custom `min` and `max` functions for the
`time.Duration` type. Go v1.21 introduced built-in functions so we can
rely on them. This PR also adds a simple test case for the existing
`exactlyOneOf` function.
---
 operator/internal/controller/pulumi/utils.go  | 18 ------
 .../internal/controller/pulumi/utils_test.go  | 60 +++++++++++++++++++
 2 files changed, 60 insertions(+), 18 deletions(-)
 create mode 100644 operator/internal/controller/pulumi/utils_test.go

diff --git a/operator/internal/controller/pulumi/utils.go b/operator/internal/controller/pulumi/utils.go
index ed59aeb4..69f9b261 100644
--- a/operator/internal/controller/pulumi/utils.go
+++ b/operator/internal/controller/pulumi/utils.go
@@ -16,24 +16,6 @@ limitations under the License.
 
 package pulumi
 
-import (
-	"time"
-)
-
-func min(a, b time.Duration) time.Duration {
-	if a < b {
-		return a
-	}
-	return b
-}
-
-func max(a, b time.Duration) time.Duration {
-	if a > b {
-		return a
-	}
-	return b
-}
-
 func exactlyOneOf(these ...bool) bool {
 	var found bool
 	for _, b := range these {
diff --git a/operator/internal/controller/pulumi/utils_test.go b/operator/internal/controller/pulumi/utils_test.go
new file mode 100644
index 00000000..20241261
--- /dev/null
+++ b/operator/internal/controller/pulumi/utils_test.go
@@ -0,0 +1,60 @@
+// Copyright 2016-2024, Pulumi Corporation.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package pulumi
+
+import "testing"
+
+func TestExactlyOneOf(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    []bool
+		expected bool
+	}{
+		{
+			name:     "No true values",
+			input:    []bool{false, false, false},
+			expected: false,
+		},
+		{
+			name:     "One true value",
+			input:    []bool{false, true, false},
+			expected: true,
+		},
+		{
+			name:     "Multiple true values",
+			input:    []bool{true, true, false},
+			expected: false,
+		},
+		{
+			name:     "All true values",
+			input:    []bool{true, true, true},
+			expected: false,
+		},
+		{
+			name:     "Empty input",
+			input:    []bool{},
+			expected: false,
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			result := exactlyOneOf(tc.input...)
+			if result != tc.expected {
+				t.Errorf("exactlyOneOf(%v) = %v; want %v", tc.input, result, tc.expected)
+			}
+		})
+	}
+}