Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider the design of infer.Annotator.SetResourceDeprecationMessage #248

Open
iwahbe opened this issue Jun 22, 2024 · 0 comments
Open

Reconsider the design of infer.Annotator.SetResourceDeprecationMessage #248

iwahbe opened this issue Jun 22, 2024 · 0 comments
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Jun 22, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

infer.Annotator.SetResourceDeprecationMessage does not fit in with the rest of the API provided by infer.Annotator. To set descriptions (similar to deprecation messages), infer.Annotator has a Describe(subject, message) method.

I would recommend that we change SetResourceDeprecationMessage to Depreciate(subject any, message string) before we 1.0 pulumi-go-provider.

Affected area/feature
@iwahbe iwahbe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team 1.0.0-blocker An issue that must be resolved before 1.0.0 labels Jun 22, 2024
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjeffryes @iwahbe