Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests around SDK generation #202

Open
blampe opened this issue Mar 20, 2024 · 0 comments
Open

Add tests around SDK generation #202

blampe opened this issue Mar 20, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Mar 20, 2024

Our examples currently generate SDKs which don't build. On main for example:

~/src/pulumi-go-provider/examples/credentials main*                                                                                                                                                                                         16:05:27
❯ go build -o pulumi-resource-credentials . && pulumi package gen-sdk ./pulumi-resource-credentials --language dotnet

~/src/pulumi-go-provider/examples/credentials main*                                                                                                                                                                                         16:05:31
❯ cd sdk/dotnet

~/src/pulumi-go-provider/examples/credentials/sdk/dotnet main*                                                                                                                                                                              16:05:34
❯ dotnet build .
Microsoft (R) Build Engine version 17.0.1+b177f8fa7 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  Restored /Users/bryce/src/pulumi-go-provider/examples/credentials/sdk/dotnet/Pulumi.Credentials.csproj (in 157 ms).
/Users/bryce/src/pulumi-go-provider/examples/credentials/sdk/dotnet/Config/Config.cs(35,127): error CS0019: Operator '??' cannot be applied to operands of type 'HashKind' and 'HashKind' [/Users/bryce/src/pulumi-go-provider/examples/credentials/sdk/dotnet/Pulumi.Credentials.csproj]

Build FAILED.

/Users/bryce/src/pulumi-go-provider/examples/credentials/sdk/dotnet/Config/Config.cs(35,127): error CS0019: Operator '??' cannot be applied to operands of type 'HashKind' and 'HashKind' [/Users/bryce/src/pulumi-go-provider/examples/credentials/sdk/dotnet/Pulumi.Credentials.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.01

We should have some sanity checks to confirm our examples generate valid SDKs.

@blampe blampe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Mar 20, 2024
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants