Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for Diffs that result in replacements #102

Open
iwahbe opened this issue Jul 25, 2023 · 0 comments
Open

Add test coverage for Diffs that result in replacements #102

iwahbe opened this issue Jul 25, 2023 · 0 comments
Labels
help-wanted We'd love your contributions on this issue kind/engineering Work that is not visible to an external user

Comments

@iwahbe
Copy link
Member

iwahbe commented Jul 25, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We don't have any test coverage that ensures diff's generate replacements as expected. We should have such tests.

Affected area/feature

infer/resources_test.go
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user good-first-issue Start here if you'd like to start contributing to Pulumi labels Jul 25, 2023
@iwahbe iwahbe mentioned this issue Jul 25, 2023
Merged
@iwahbe iwahbe added help-wanted We'd love your contributions on this issue and removed good-first-issue Start here if you'd like to start contributing to Pulumi labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted We'd love your contributions on this issue kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iwahbe