Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elastic Fabric Adapter in managed node groups #1564

Open
pierskarsenbarg opened this issue Dec 26, 2024 · 1 comment
Open

Support Elastic Fabric Adapter in managed node groups #1564

pierskarsenbarg opened this issue Dec 26, 2024 · 1 comment
Assignees
Labels
kind/enhancement Improvements or new features

Comments

@pierskarsenbarg
Copy link
Member

pierskarsenbarg commented Dec 26, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

AWS added ability to support elastic fabric adapter in EKS: https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-eks-supports-elastic-fabric-adapter/

Can we add this in to the managed node groups? Is there currently a workaround to enable this (I couldn't see anything in the base AWS provider)

Affected area/feature

@pierskarsenbarg pierskarsenbarg added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Dec 26, 2024
@flostadler
Copy link
Contributor

@pierskarsenbarg The managed node groups already support EFA. This is not a node group or cluster setting (i.e. nothing configurable via AWS APIs).

You'll need to choose an instance type that has EFA support (e.g. p5.48xlarge), add the EFA interfaces to the launch template and then install the aws-efa-k8s-device-plugin helm chart.

What we could do provider side is expose a flag (e.g. enabledEfaSupport) or auto detect instances with EFA support and add the EFA interfaces to the launch template.

@flostadler flostadler removed the needs-triage Needs attention from the triage team label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants