Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default resource state for SqlVulnerabilityAssessmentsSetting #3935

Closed
wants to merge 1 commit into from

Conversation

JasonWhall
Copy link
Contributor

fixes #3934

Set default state for Vulnerability Assessment Setting to allow resource to be managed using Pulumi.

Copy link

github-actions bot commented Feb 7, 2025

Hi there 👋 Thank you for submitting a pull request.

Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack.

Maintainers: Please review changes then run tests by adding the comment:

/run-acceptance-tests

@mjeffryes
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@JasonWhall
Copy link
Contributor Author

Looks like the tests have failed for unrelated reasons. One of the tests use a legacy Defender for Storage plan which is no longer supported - https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-storage-classic-migrate

I can have a look at fixing up as part of this pr, I believe it should just be a change from Advanced threat protection resource to defender for storage settings resource

@thomas11
Copy link
Contributor

thomas11 commented Feb 8, 2025

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@thomas11
Copy link
Contributor

thomas11 commented Feb 8, 2025

Looks like the tests have failed for unrelated reasons. One of the tests use a legacy Defender for Storage plan which is no longer supported

I've fixed that in #3938, just need approval to merge it. Thank you for your PR!

- Resource cannot be deleted or created as it has the same lifecycle as the SQL Server resource.
- Set the default state back to what is observed when the resource is first created.
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, compare the spec here

@thomas11
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

thomas11 added a commit that referenced this pull request Feb 10, 2025
)

fixes #3934

Set default state for Vulnerability Assessment Setting to allow resource
to be managed using Pulumi.

This PR recreates #3935 so the CI tests can run.

Co-authored-by: JasonWhall <[email protected]>
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Feb 10, 2025
@thomas11
Copy link
Contributor

replaced by #3941

@thomas11 thomas11 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create SqlVulnerabilityAssessmentSetting
4 participants