-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default resource state for SqlVulnerabilityAssessmentsSetting #3935
Conversation
Hi there 👋 Thank you for submitting a pull request. Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack. Maintainers: Please review changes then run tests by adding the comment:
|
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-azure-native/actions/runs/13208150668 |
Looks like the tests have failed for unrelated reasons. One of the tests use a legacy Defender for Storage plan which is no longer supported - https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-storage-classic-migrate I can have a look at fixing up as part of this pr, I believe it should just be a change from Advanced threat protection resource to defender for storage settings resource |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-azure-native/actions/runs/13217563902 |
I've fixed that in #3938, just need approval to merge it. Thank you for your PR! |
- Resource cannot be deleted or created as it has the same lifecycle as the SQL Server resource. - Set the default state back to what is observed when the resource is first created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, compare the spec here
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-azure-native/actions/runs/13238371533 |
) fixes #3934 Set default state for Vulnerability Assessment Setting to allow resource to be managed using Pulumi. This PR recreates #3935 so the CI tests can run. Co-authored-by: JasonWhall <[email protected]>
replaced by #3941 |
fixes #3934
Set default state for Vulnerability Assessment Setting to allow resource to be managed using Pulumi.