From bc49058158c6cea1193a98285b4856427257652f Mon Sep 17 00:00:00 2001 From: Florian Stadler Date: Fri, 28 Jun 2024 16:39:57 +0200 Subject: [PATCH] Fix make target "discovery" by correctly escaping commands (#1611) The awk command of the `discovery` make target was not correctly escaped and ended up discovering the wrong version. Instead of detecting `8bed56da0b8e0f6bb7c2d255194694bba97bb28f` it detected `8bed56da0b8e0f6bb7c2d255194694bba97bb28f refs/heads/main` which ended up breaking the docs generation. fixes #1609 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 0160a0dcb7..a948096998 100644 --- a/Makefile +++ b/Makefile @@ -42,7 +42,7 @@ docs:: .docs.version $(WORKING_DIR)/bin/$(CODEGEN) -schema-folder $(CFN_SCHEMA_DIR) -version ${VERSION_GENERIC} -docs-url https://github.com/cdklabs/awscdk-service-spec/raw/${DOCS_VERSION}/sources/CloudFormationDocumentation/CloudFormationDocumentation.json docs discovery:: update_submodules codegen - git ls-remote https://github.com/cdklabs/awscdk-service-spec refs/heads/main | awk '{print $1}' > .docs.version + git ls-remote https://github.com/cdklabs/awscdk-service-spec refs/heads/main | awk '{print $$1}' > .docs.version $(WORKING_DIR)/bin/$(CODEGEN) -schema-folder $(CFN_SCHEMA_DIR) -version ${VERSION_GENERIC} -schema-urls https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip,https://schema.cloudformation.us-west-2.amazonaws.com/CloudformationSchema.zip discovery ensure:: init_submodules