Provide pulp_rpm urlencode solution to plugins via the plugin API

[quba42]

Is your feature request related to a problem? Please describe.
pulp_deb users have reported the following issue: pulp/pulp_deb#571
It looks like pulp_rpm has solved the exact same issue for pulp_rpm a long time ago here under this issue.

Describe the solution you'd like
Since this now affects multiple plugins, it would be nice if the pulp_rpm solution could be provided to plugins by pulpcore.
Ideally using the downloader from pulpcore would "just work" for everyone, but given the ongoing design discussions around downloaders and the pulp_rpm solution describing itself as "a pretty ugly workaround" perhaps just provide it as a small utility function requiring opt-in from plugin authors?

Describe alternatives you've considered
We simply copy the pulp_rpm fix within pulp_deb and maybe wait for the "Pulp downloader redesign" to conclude before asking for a general solution from pulpcore.

[dralley]

I actually encountered another edge case related to this today.

I'm thinking that perhaps we need to push this further upstream because it's actually not possible to fix every case using the workarounds in pulp_rpm.

See:

aio-libs/aiohttp#5319
aio-libs/yarl#301
aio-libs/yarl#245

[bmbouter]

Yes I agree, this needs to be solved in either aiohttp or even better yarl.

[quba42]

Update: We have a workaround for the original pulp_deb issue that prompted me to open this here: pulp/pulp_deb#573

But it still feels like handling download URL strings ultimately should not be plugin responsibility.

[dralley]

Update, the pulpcore problem I mentioned was resolved with an existing flag that I overlooked, requote_redirect_url=False

[bmbouter]

@dralley with that flag now in use on main should this issue be closed?

[dralley]

No, this issue is separate (but related). The original URL passed in by plugin writer code still needs to be handled in a certain way.