Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo Package files with blank custom fields with fail to parse #1225

Open
tokfrans03 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1226
Open

Repo Package files with blank custom fields with fail to parse #1225

tokfrans03 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1226
Labels
Triage-Needed

Comments

@tokfrans03
Copy link

Version
main (a193cc1)

Describe the bug
If there's a blank custom field in the Packages index, sync fails.

This issue prevents some repos from syncing including for example Kali Rolling and other.

From https://packages.microsoft.com/repos/aplinux-prod/dists/xenial/main/binary-amd64/Packages:

Package: aplinux-geneva-mdsd-azsecpack
Version: 0.1.427-release-aplinux-rc3
Architecture: amd64
--- snip ---
Build-Depends:    
^^^^^^^^^^^^^^^^^  This will error
SHA256: 5b5f95a67507ae82f797937116d7ce022480fed916def156a5a32a3b487e33af
Size: 8230

To Reproduce

pulp deb remote create --name aplinux --url "https://packages.microsoft.com/repos/aplinux-prod/" --distribution xenial --architecture amd64
pulp deb repository create --name aplinux --remote aplinux
pulp deb repository sync --name aplinux

Output

Started background task /pulp/api/v3/tasks/1b8ffdc3-fbb1-43d2-bb75-902c2e4a3317/
.Error: Task /pulp/api/v3/tasks/1b8ffdc3-fbb1-43d2-bb75-902c2e4a3317/ failed: '{'custom_fields': {'Build-Depends': [ErrorDetail(string='This field may not be blank.', code='blank')]}}'

Expected behavior
The sync should ignore empty custom fields as it does with known ones and should be completed and not fail.

Additional context
The issue #694 is identical but daviddavis's proposed fix #695 got closed.

This issue has a different implementation
@tokfrans03 tokfrans03 linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Triage-Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop custom fields with empty values tokfrans03/pulp_deb
1 participant
@tokfrans03