Skip to content

replace patternfly/react-core/deprecated imports #132

Open
@himdel

Description

@himdel

Patternfly 6 is out (https://github.com/patternfly/patternfly/releases/tag/v6.0.0; via #129; https://staging-v6.patternfly.org/get-started/release-highlights)

To switch, we'll need to s/pf-v5-/pf-v6-/g everywhere, and resolve a bunch of issues including masthead not rendering...

But the largest issue will be moving off of deprecated imports (while staying with pf5):

$ sg -p 'import $$$ from '\''@patternfly/react-core/deprecated'\'
./src/components/language-switcher.tsx
2│import {
3│  DropdownItem,
4│  DropdownSeparator,
5│} from '@patternfly/react-core/deprecated';

./src/layout.tsx
13│import {
14│  DropdownItem,
15│  DropdownSeparator,
16│} from '@patternfly/react-core/deprecated';

./src/actions/action.tsx
3│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/signature-keys/list.tsx
8│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/execution-environment-list/execution-environment-list.tsx
10│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/compound-filter.tsx
9│import {
10│  DropdownItem,
11│  Select,
12│  SelectGroup,
13│  SelectOption,
14│  SelectVariant,
15│} from '@patternfly/react-core/deprecated';

./src/components/typeahead.tsx
2│import {
3│  Select,
4│  SelectOption,
5│  SelectVariant,
6│} from '@patternfly/react-core/deprecated';

./src/containers/execution-environment/registry-list.tsx
9│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/user-management/user-list.tsx
10│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/role-management/role-list.tsx
9│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/sort.tsx
2│import {
3│  Select,
4│  SelectOption,
5│  SelectVariant,
6│} from '@patternfly/react-core/deprecated';

./src/components/access-tab.tsx
8│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/group-management/group-list.tsx
9│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/group-management/group-detail-role-management/group-detail-role-management.tsx
9│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/darkmode-switcher.tsx
2│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/approval-row.tsx
3│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/permission-chip-selector.tsx
3│import {
4│  Select,
5│  SelectOption,
6│  SelectVariant,
7│} from '@patternfly/react-core/deprecated';

./src/containers/execution-environment-detail/execution-environment-detail-images.tsx
11│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/collection-dropdown.tsx
2│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/multiple-repo-selector.tsx
10│import {
11│  Dropdown,
12│  DropdownItem,
13│  DropdownToggle,
14│  DropdownToggleCheckbox,
15│} from '@patternfly/react-core/deprecated';

./src/components/stateful-dropdown.tsx
2│import {
3│  Dropdown,
4│  DropdownPosition,
5│  DropdownToggle,
6│  KebabToggle,
7│} from '@patternfly/react-core/deprecated';

./src/containers/group-management/group-detail.tsx
10│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/containers/execution-environment-detail/base.tsx
3│import { DropdownItem } from '@patternfly/react-core/deprecated';

./src/components/collection-header.tsx
11│import {
12│  Select,
13│  SelectOption,
14│  SelectVariant,
15│} from '@patternfly/react-core/deprecated';

./src/containers/namespace-detail/namespace-detail.tsx
3│import { DropdownItem } from '@patternfly/react-core/deprecated';

The components/types we need to replace are:

  • DropdownItem (20x)
  • SelectVariant (5x)
  • SelectOption (5x)
  • Select (5x)
  • DropdownToggle (2x)
  • DropdownSeparator (2x)
  • Dropdown (2x)
  • SelectGroup
  • KebabToggle
  • DropdownToggleCheckbox
  • DropdownPosition

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions