Make pytest timeout configurable and with higher defaults #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to catch unexpected hanging tasks and have meaningful traceback, so it is not so important to try to minimize the timeout as it is to not have long test failing because they are on the edge. 01h sounds safe?
|
You can use |
|
Sounds fair. I did consider overriding the specific test, but was not sure it was the best option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated here, the timeout is meant to catch unexpected hanging tasks and have to meaningful stacktrace.
Then, it is not so important to minimize the timeout as it is to prevent long testing from failing unexpectedly, so I think we can raise the bar here.
01h sounds safe in general?
Context
This rpm test was failing due to the timeout and took me some time to realize this was this pytest-timeout plugin. On my machine it ran in 38m.