-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misformatted changelog on "Update Changelog" PR #907
Labels
Comments
pedro-psb
added a commit
to pedro-psb/pulpcore
that referenced
this issue
Aug 14, 2024
It's not yet clear why it was misformatted, but while we figure it out it's better to patch those. Being tracked on pulp/plugin_template#907 [noissue]
pedro-psb
added a commit
to pedro-psb/pulpcore
that referenced
this issue
Aug 14, 2024
It's not yet clear why it was misformatted, but while we figure it out it's better to patch those. Being tracked on pulp/plugin_template#907 [noissue]
AFAIK this appeared originally on 3.57 branch release (pulp/pulpcore@a5c9aec), which is generated by https://github.com/pulp/pulpcore/blob/main/.github/workflows/scripts/release.sh. By going back to the 3.57.0 release parent commit and running the release.sh commands (basically towncrier) I wasnt able to reproduce it. |
dkliban
pushed a commit
to pulp/pulpcore
that referenced
this issue
Aug 14, 2024
It's not yet clear why it was misformatted, but while we figure it out it's better to patch those. Being tracked on pulp/plugin_template#907 [noissue]
dkliban
pushed a commit
to pulp/pulpcore
that referenced
this issue
Aug 14, 2024
It's not yet clear why it was misformatted, but while we figure it out it's better to patch those. Being tracked on pulp/plugin_template#907 [noissue]
Sounds like we should just observe if this ever happens again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A recent "Update Changelog" PR on pulpcore added a malformed title which broke the changelog ToC page.
See here: pulp/pulpcore@8afdd1a#r145350978
I didn't look into it yet, but maybe it's something that needs adjusting in the collect_changes script.
Screenshot
The text was updated successfully, but these errors were encountered: