Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Use GH-labels to flag a PR that has [noissue] or multiple commits #496

Open
mdellweg opened this issue Sep 15, 2021 · 2 comments
Open
Labels

Comments

@mdellweg
Copy link
Member

The idea is that the PR CI can set (clear) labels about the state of the commits.

  • noissue in case, any commit message contains [noissue] - reviewers should take extra care if those commits are suitable for not having an issue
  • multi-commit in case the PR contains more than one commit - reviewers should judge if the changes suitable to be split into seperate commits, and occasionally request to split the PR or merge the commits

Simple PR's would not have these labels.

@quba42
Copy link
Contributor

quba42 commented Sep 15, 2021

I personally like the idea/approach, and I also have a possible extension for it:

Automatically add a .feature, .bugfix, etc. labels for PRs that do have a changelog entry. I recently missed during review that a PR was using .misc instead of .bugfix, which can be pretty annoying if the change needs to be cherry-picked later. (I think a correct changelog categorization is fairly important!)

@stale
Copy link

stale bot commented May 24, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants