Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release branch creation workflow needs to require all parameters needed to update requirements.txt and GHA configs #419

Open
dkliban opened this issue Jun 22, 2021 · 4 comments
Assignees
Labels

Comments

@dkliban
Copy link
Member

dkliban commented Jun 22, 2021

The release workflow is changing the required pulpcore version in the commit that bumps the version of the plugin. The required version of pulpcore should not change.

@dkliban dkliban self-assigned this Jun 22, 2021
@daviddavis
Copy link
Contributor

I was imagining that the upper pulpcore version gets set when the release branch is created. And then never gets unset unless the plugin writer confirms that newer versions of pulpcore are compatible with their y-release branch.

@mdellweg
Copy link
Member

I was imagining that the upper pulpcore version gets set when the release branch is created. And then never gets unset unless the plugin writer confirms that newer versions of pulpcore are compatible with their y-release branch.

Can this be accompanied with a check, that the release workflow cannot be started from the main branch?

@dkliban
Copy link
Member Author

dkliban commented Jun 24, 2021

The initial bug report I wrote up does not actually exist. However, I would like to repurpose this issue to add a check that the release job can't be run on master branch.

@dkliban dkliban changed the title Release pipeline workflow removes upper pulpcore version requirement after release Release branch creation workflow needs to require all parameters needed to update requirements.txt and GHA configs Jul 14, 2021
@stale
Copy link

stale bot commented May 24, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants