From 889b3e9214a04bdb5945da7821fcdce6d340cd97 Mon Sep 17 00:00:00 2001
From: Hector Correa <hector_correa@princeton.edu>
Date: Wed, 21 Aug 2024 17:51:42 +0200
Subject: [PATCH] Adds email to list of values we display for the user

---
 app/assets/stylesheets/application.scss |  4 ++++
 app/views/users/_form.html.erb          | 11 ++++++++---
 spec/system/user_edit_spec.rb           | 10 ++++++++++
 3 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss
index 2e7657d10..8f9deb906 100644
--- a/app/assets/stylesheets/application.scss
+++ b/app/assets/stylesheets/application.scss
@@ -385,3 +385,7 @@ div.form-subcommunities .form-check{
 table.dataTable {
   overflow-wrap: anywhere
 }
+
+.user-edit-long-field {
+  width: 400px;
+}
diff --git a/app/views/users/_form.html.erb b/app/views/users/_form.html.erb
index fe03a55e1..d8735b3e8 100644
--- a/app/views/users/_form.html.erb
+++ b/app/views/users/_form.html.erb
@@ -9,7 +9,7 @@
         </div>
       </fieldset>
 
-      <section class="card container groups"> 
+      <section class="card container groups">
         <h2><%= t('users.form.group') %></h2>
         <fieldset>
           <% @user.submitter_or_admin_groups.each do |group| %>
@@ -75,14 +75,19 @@
     <%= form.text_field :orcid, placeholder: "0000-0000-0000-0000" %>
   </div>
 
+  <div class="field">
+    Email<br />
+    <input id="email" type="text" class="user-edit-long-field" disabled value="<%= @user.email %>" />
+  </div>
+
   <div class="field">
     Princeton Net ID<br />
-    <input type="text" disabled value="<%= @user.uid %>" />
+    <input id="netid" type="text" class="user-edit-long-field" disabled value="<%= @user.uid %>" />
   </div>
 
   <div class="field">
     Default group<br />
-    <input type="text" disabled value="<%= @user.default_group.title %>" />
+    <input id="default_group" type="text" class="user-edit-long-field" disabled value="<%= @user.default_group.title %>" />
   </div>
 
   <div class="text-left">
diff --git a/spec/system/user_edit_spec.rb b/spec/system/user_edit_spec.rb
index 1c76da5d2..1ca719c16 100644
--- a/spec/system/user_edit_spec.rb
+++ b/spec/system/user_edit_spec.rb
@@ -16,6 +16,16 @@
       fill_in "user_orcid", with: orcid
       click_on "Save"
     end
+
+    it "shows user fields", js: true do
+      visit edit_user_path(user_admin)
+      # These fields are disabled so we cannot target them with
+      # RSpec `have_field`, but once we make them editable we
+      # could use the more common syntax.
+      expect(page.html.include?(user_admin.email)).to be true
+      expect(page.html.include?(user_admin.uid)).to be true
+      expect(page.html.include?(user_admin.default_group.title)).to be true
+    end
   end
 
   describe "Non-admin users cannot access others people data" do