Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code related to CDL #4356

Closed
1 of 5 tasks
christinach opened this issue Sep 17, 2024 · 0 comments · Fixed by #4610
Closed
1 of 5 tasks

Remove code related to CDL #4356

christinach opened this issue Sep 17, 2024 · 0 comments · Fixed by #4610
Assignees
@vh8154
Labels
maintenance Ticket related to maintenance that needs to be done

Comments

@christinach
Copy link
Member

christinach commented Sep 17, 2024 •
edited
Loading

What maintenance needs to be done?

Rails Code related to CDL should be removed
Javascript related to CDL should be removed

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

  • The feature is no longer active in Figgy. We don't know if and when it will be active again. If it comes back most likely will be configured in a different way in Alma.

Acceptance criteria

  • Remove code related to CDL
  • Remove tests related to CDL

Implementation notes, if any

Search the repository for cdl references
also def holding_block_search(document)
@christinach christinach added the maintenance Ticket related to maintenance that needs to be done label Sep 17, 2024
@christinach christinach changed the title Turn off CDL Remove code related to CDL Sep 19, 2024
@christinach christinach removed their assignment Dec 2, 2024
vh8154 added a commit that referenced this issue Dec 3, 2024
@vh8154
[#4356] Remove cdl references
69ddde5
@vh8154 vh8154 mentioned this issue Dec 4, 2024
Merged
christinach pushed a commit that referenced this issue Jan 2, 2025
@vh8154 @christinach
[#4356] Remove cdl references
1b96962
christinach added a commit that referenced this issue Jan 2, 2025
@vh8154 @christinach
[#4356] Remove cdl references
67fdad5 
Co-authored-by: Christina Chortaria <[email protected]>
christinach added a commit that referenced this issue Jan 2, 2025
@vh8154 @christinach
[#4356] Remove cdl references
62b1d3a 
Co-authored-by: Christina Chortaria <[email protected]>
christinach added a commit that referenced this issue Jan 2, 2025
@vh8154 @christinach
[#4356] Remove cdl references
1b988d8 
Co-authored-by: Christina Chortaria <[email protected]>
christinach added a commit that referenced this issue Jan 2, 2025
@christinach
Merge pull request #4610 from pulibrary/4356-remove-cdl
6829dfe 
[#4356] Remove cdl references
@github-project-automation github-project-automation bot moved this from In Progress to Done in DACS - student software dev board Jan 2, 2025
@christinach christinach mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vh8154 vh8154

Labels
maintenance Ticket related to maintenance that needs to be done
Projects
DACS - student software dev board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4356] Remove cdl references pulibrary/orangelight
2 participants
@christinach @vh8154