From c0bb662ea535cd3155cbfd4eb0d1868fa0c60aa0 Mon Sep 17 00:00:00 2001 From: Max Kadel Date: Wed, 24 Jul 2024 13:40:27 -0400 Subject: [PATCH] Update column for first name from airtable (#820) Closes #819 --- app/models/air_table_staff/staff_directory_mapping.rb | 2 +- spec/fixtures/files/air_table/records_no_offset.json | 2 +- spec/fixtures/files/air_table/records_with_offset.json | 2 +- spec/models/air_table_staff/record_list_spec.rb | 2 +- spec/models/air_table_staff/staff_directory_person_spec.rb | 2 +- spec/support/stub_airtable.rb | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/air_table_staff/staff_directory_mapping.rb b/app/models/air_table_staff/staff_directory_mapping.rb index 149b0b65..474fb151 100644 --- a/app/models/air_table_staff/staff_directory_mapping.rb +++ b/app/models/air_table_staff/staff_directory_mapping.rb @@ -18,7 +18,7 @@ def fields { airtable_field: :'University Phone', airtable_field_id: :fldqulY6ehd5aIbR1, our_field: :phone }, { airtable_field: :'pul:Preferred Name', airtable_field_id: :fldL7tm4jVvYksIwl, our_field: :name }, { airtable_field: :'Last Name', airtable_field_id: :fldcGj6p3JRzHzmZ8, our_field: :lastName }, - { airtable_field: :'First Name', airtable_field_id: :fldL5IJdMuz8UCM81, our_field: :firstName }, + { airtable_field: :'pul:First Name', airtable_field_id: :fldnKprqGraSvNTJK, our_field: :firstName }, { airtable_field: :Email, airtable_field_id: :fldbnDHHhDNlc2Lx8, our_field: :email }, { airtable_field: :Address, airtable_field_id: :fldKZxmtofNbXW4qS, our_field: :address }, { airtable_field: :'pul:Building', airtable_field_id: :fldz6yBenvTjdClXZ, our_field: :building }, diff --git a/spec/fixtures/files/air_table/records_no_offset.json b/spec/fixtures/files/air_table/records_no_offset.json index e8bd1225..3a872f07 100644 --- a/spec/fixtures/files/air_table/records_no_offset.json +++ b/spec/fixtures/files/air_table/records_no_offset.json @@ -9,7 +9,7 @@ "fldxpCzkJmhEkVqZt": "Stokes", "fldz6yBenvTjdClXZ": "Stokes", "fldcGj6p3JRzHzmZ8": "Librarian", - "fldL5IJdMuz8UCM81": "Phillip", + "fldnKprqGraSvNTJK": "Phillip", "fldw0mjDdB48HstnB": "Library Collections Specialist V", "fldbquJ6Hn2eq1V2h": "123", "fldgarsg3FzD8xpE4": "ab123", diff --git a/spec/fixtures/files/air_table/records_with_offset.json b/spec/fixtures/files/air_table/records_with_offset.json index d2007f59..6b64c574 100644 --- a/spec/fixtures/files/air_table/records_with_offset.json +++ b/spec/fixtures/files/air_table/records_with_offset.json @@ -9,7 +9,7 @@ "fldxpCzkJmhEkVqZt": "Special Collections", "fldz6yBenvTjdClXZ": "Firestone", "fldcGj6p3JRzHzmZ8": "Carmant", - "fldL5IJdMuz8UCM81": "Drema", + "fldnKprqGraSvNTJK": "Drema", "fldbquJ6Hn2eq1V2h": "456", "fldgarsg3FzD8xpE4": "zz99", "fldqulY6ehd5aIbR1": "(123) 555-5555", diff --git a/spec/models/air_table_staff/record_list_spec.rb b/spec/models/air_table_staff/record_list_spec.rb index eba10853..af39b3a1 100644 --- a/spec/models/air_table_staff/record_list_spec.rb +++ b/spec/models/air_table_staff/record_list_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'rails_helper' -BASE_AIRTABLE_URL = 'https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldL5IJdMuz8UCM81&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldcGj6p3JRzHzmZ8&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true' +BASE_AIRTABLE_URL = 'https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldcGj6p3JRzHzmZ8&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true' RSpec.describe AirTableStaff::RecordList do context 'when the airtable response is not paginated' do diff --git a/spec/models/air_table_staff/staff_directory_person_spec.rb b/spec/models/air_table_staff/staff_directory_person_spec.rb index 4d7363b1..c0d034bd 100644 --- a/spec/models/air_table_staff/staff_directory_person_spec.rb +++ b/spec/models/air_table_staff/staff_directory_person_spec.rb @@ -10,7 +10,7 @@ 'fldgarsg3FzD8xpE4': 'ab1234', 'fldqulY6ehd5aIbR1': '(609) 555-1234', 'fldcGj6p3JRzHzmZ8': 'Archivist', - 'fldL5IJdMuz8UCM81': 'Phoenix', + 'fldnKprqGraSvNTJK': 'Phoenix', 'fldbnDHHhDNlc2Lx8': 'test@princeton.edu', 'fldKZxmtofNbXW4qS': '123 Lewis Library', 'fldz6yBenvTjdClXZ': 'Stokes Library', diff --git a/spec/support/stub_airtable.rb b/spec/support/stub_airtable.rb index cdbb3eb1..8830896b 100644 --- a/spec/support/stub_airtable.rb +++ b/spec/support/stub_airtable.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true module AirtableStubbing - BASE_AIRTABLE_URL = "https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldL5IJdMuz8UCM81&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldcGj6p3JRzHzmZ8&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true" + BASE_AIRTABLE_URL = "https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldcGj6p3JRzHzmZ8&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true" def stub_airtable(offset: false) if offset stub_airtable_with_offset