From 87c0dc19906ac33b68fa8c9919df395c58edb119 Mon Sep 17 00:00:00 2001
From: Max Kadel <mkadel@princeton.edu>
Date: Mon, 24 Jun 2024 16:35:30 -0400
Subject: [PATCH] Add Title to staff csv

Closes #797
---
 app/models/air_table_staff/staff_directory_mapping.rb      | 1 +
 spec/fixtures/files/air_table/records_no_offset.json       | 1 +
 spec/models/air_table_staff/csv_builder_spec.rb            | 4 ++--
 spec/models/air_table_staff/staff_directory_person_spec.rb | 2 ++
 spec/models/air_table_staff/staff_list_job_spec.rb         | 3 ++-
 5 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/models/air_table_staff/staff_directory_mapping.rb b/app/models/air_table_staff/staff_directory_mapping.rb
index fabc0285..584f9c57 100644
--- a/app/models/air_table_staff/staff_directory_mapping.rb
+++ b/app/models/air_table_staff/staff_directory_mapping.rb
@@ -24,6 +24,7 @@ def fields
         { airtable_field: :'pul:Department', our_field: :division },
         { airtable_field: :'pul:Unit', our_field: :unit },
         { airtable_field: :'pul:Team', our_field: :team },
+        { airtable_field: :Title, our_field: :title },
         { airtable_field: :'Area of Study', our_field: :areasOfStudy, transformer: ->(areas) { areas&.join('//') } }
       ]
     end
diff --git a/spec/fixtures/files/air_table/records_no_offset.json b/spec/fixtures/files/air_table/records_no_offset.json
index 3d3efdf8..e32faeee 100644
--- a/spec/fixtures/files/air_table/records_no_offset.json
+++ b/spec/fixtures/files/air_table/records_no_offset.json
@@ -10,6 +10,7 @@
                 "pul:Building": "Stokes",
                 "Last Name": "Librarian",
                 "First Name": "Phillip",
+                "Title": "Library Collections Specialist V",
                 "University ID": "123",
                 "netid": "ab123",
                 "University Phone": "(123) 123-1234",
diff --git a/spec/models/air_table_staff/csv_builder_spec.rb b/spec/models/air_table_staff/csv_builder_spec.rb
index bad732b0..dd324655 100644
--- a/spec/models/air_table_staff/csv_builder_spec.rb
+++ b/spec/models/air_table_staff/csv_builder_spec.rb
@@ -13,8 +13,8 @@
   end
   it 'creates a CSV object with data from the HTTP API' do
     expected = <<~END_CSV
-            puid,netid,phone,name,lastName,firstName,email,address,building,department,division,unit,team,areasOfStudy
-            123,ab123,(123) 123-1234,Phillip Librarian,Librarian,Phillip,ab123@princeton.edu,123 Stokes,Stokes,Stokes,,,,Virtual Reality
+            puid,netid,phone,name,lastName,firstName,email,address,building,department,division,unit,team,title,areasOfStudy
+            123,ab123,(123) 123-1234,Phillip Librarian,Librarian,Phillip,ab123@princeton.edu,123 Stokes,Stokes,Stokes,,,,Library Collections Specialist V,Virtual Reality
         END_CSV
     directory = described_class.new
     expect(directory.to_csv).to eq(expected)
diff --git a/spec/models/air_table_staff/staff_directory_person_spec.rb b/spec/models/air_table_staff/staff_directory_person_spec.rb
index c37eb24e..491a0cf0 100644
--- a/spec/models/air_table_staff/staff_directory_person_spec.rb
+++ b/spec/models/air_table_staff/staff_directory_person_spec.rb
@@ -18,6 +18,7 @@
         'pul:Department': 'Cataloging and Metadata Services',
         'pul:Unit': 'Rare Books Cataloging Team',
         'pul:Team': 'IT, Discovery and Access Services',
+        'Title': 'Library Software Engineer',
         'Area of Study': ['Chemistry', 'African American Studies']
       }
       expected = [
@@ -34,6 +35,7 @@
         'Cataloging and Metadata Services', # division
         'Rare Books Cataloging Team', # unit
         'IT, Discovery and Access Services', # team
+        'Library Software Engineer', # title
         'Chemistry//African American Studies' # areasOfStudy
       ]
 
diff --git a/spec/models/air_table_staff/staff_list_job_spec.rb b/spec/models/air_table_staff/staff_list_job_spec.rb
index 0c866066..a70aa457 100644
--- a/spec/models/air_table_staff/staff_list_job_spec.rb
+++ b/spec/models/air_table_staff/staff_list_job_spec.rb
@@ -21,7 +21,8 @@
       let(:file_path) { Pathname.new(Rails.root.join('tmp', "airtable_staff.csv")) }
       let(:first_row) do
         [
-          '123', 'ab123', '(123) 123-1234', 'Phillip Librarian', 'Librarian', 'Phillip', 'ab123@princeton.edu', '123 Stokes', 'Stokes', 'Stokes', nil, nil, nil, 'Virtual Reality'
+          '123', 'ab123', '(123) 123-1234', 'Phillip Librarian', 'Librarian', 'Phillip', 'ab123@princeton.edu',
+          '123 Stokes', 'Stokes', 'Stokes', nil, nil, nil, 'Library Collections Specialist V', 'Virtual Reality'
         ]
       end