Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes and or mixins sometimes do not trigger changes in parents while watching #131

Open
spence-s opened this issue Jan 24, 2021 · 1 comment

Comments

@spence-s
Copy link

spence-s commented Jan 24, 2021

There are some weird issues with includes that have been addressed in other open issues. But I wanted to document another issue that has been a pain point for me, in that I think the includes are treated as orphaned modules, and when a change in an included template occurs, the cache is not correctly invalidated and webpack watch will only rebuild the module and not the containing chunk. - could be wrong about the specifics of what's going on here, but it requires stopping webpack watch and rebuilding the the bundles from scratch to get the changes from child includes to propagate into the parent chunks.

I don't think this is all scenarios, but definitely some. Also, I want to start using new persistent cache features and this makes me weary that those file changes won't bust the cache properly - although I haven't tested against this.

@spence-s spence-s changed the title Includes do not trigger changes in parents while watching Includes and or mixins sometimes do not trigger changes in parents while watching Jan 24, 2021
@spence-s
Copy link
Author

spence-s commented Feb 1, 2021

I published a package that fixes these problems for me as well as some of the other issues with this loader and predictable variable scoping with includes and mixins.

https://www.npmjs.com/package/simple-pug-loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant