Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package still being maintained? #124

Open
Javiani opened this issue Dec 26, 2019 · 43 comments
Open

Is this package still being maintained? #124

Javiani opened this issue Dec 26, 2019 · 43 comments

Comments

@Javiani
Copy link

Javiani commented Dec 26, 2019

Hi!

I see that there aren't many stars but there are a lot of people using this package, but it has being a while since it was updated for the last time...

I'm using pug today and it's very useful in many cases, and I'm trying to use it with storybook but there's a flaw on this loader... I can't import a file that has a mixin on it. It always returns a empty template.

Man, that bug it's killing me... Please don't let this project die... It fells like there's no other option than those complicated framework out there... Pug is way better and simpler... please do not give up on this package... there are too many people using it...

@matheo
Copy link

matheo commented Jan 27, 2020

@TimothyGu seems active but working on other projects :(

@alexander-akait
Copy link

/cc @ForbesLindesay We want to provide official supporting from webpack team to pug and move this repo to webpack-contrib? Can you help us?

We need:

  1. You need to send a PR with updating license on JS Foundation (https://github.com/webpack-contrib/css-loader/blob/master/LICENSE), we are not trying to steal the code, we just want to protect our users from the fact that in the future the original developer may want to change the license, you can save your name in any other places (package.json/comments in code/other, we never remove it)
  2. Give me github and npm permissions
  3. I will more this repo to webpack-contrib
  4. We resolve issues and do new major release.

@matheo
Copy link

matheo commented Sep 3, 2020

awesome stuff @alexander-akait
I hope you get an answer :)

@alexander-akait
Copy link

Friendly ping @ForbesLindesay and @TimothyGu

@spence-s
Copy link

spence-s commented Dec 18, 2020

This would be great and give a little more piece of mind to everyone depending on this loader. Hope it gets migrated soon!

@alexander-akait
Copy link

No answer from developers 😞

@alexander-akait
Copy link

I could have done it long ago

@Rush
Copy link

Rush commented Jan 19, 2021

Agreed this would be great. @alexander-akait - could the original developers be tracked elsewhere? For example LinkedIn or email (extracted from commits).

@alexander-akait
Copy link

@Rush I tried to connect using twitter, but no luck

@mrmowgli
Copy link

The current license suggests that moving it would be fine. Also it looks like it was originally maintained by someone else. The only downside to moving it is no-one will update this package and list it as unmaintained or to look for it at webpack-contrib.

@alexander-akait
Copy link

Written @ForbesLindesay in twitter DM again, maybe we will succeed

@Rush
Copy link

Rush commented Jan 20, 2021

He actually appears to be active on Github in general. I also sent him an email and linked this thread.

@m10
Copy link

m10 commented Jan 22, 2021

maybe @sokra can help?
he startet the project in 2012 02e8aa9

@alexander-akait
Copy link

@christopherdowson
Copy link
Member

@alexander-akait Sorry, I only created the logo. I've not worked with anyone on the project in a few years.

@sokra
Copy link
Collaborator

sokra commented Jan 22, 2021

maybe @sokra can help?

I have npm permission, but I don't have github permission. If someone could give @alexander-akait or me admin access to this repo we could move it over or keep it here and allow someone to maintain it here.

@m10
Copy link

m10 commented Mar 6, 2021

Any updates on this?
It's been 6 months since @alexander-akait requesting maintenance #124 (comment) .
No activity from maintainers, no commits since 3+ years etc. The chances of getting hold of them seem slim?
What are the options to go forward without the help of the maintainers?
Could you fork it? 😱
I'd love to use pug with webpack, but without a proper loader that is being maintained this is not feasible with the outstanding issues at the moment 😞

@matheo
Copy link

matheo commented Mar 6, 2021

And recently I had issues with pug-lint outdated dependencies 😱

@tjconcept
Copy link
Member

I've added @sokra as an admin. I have had next to nothing to do with Pug and it's been years since I've been writing any serious amounts of HTML, although I still occasionally update a project using Pug.

@sokra
Copy link
Collaborator

sokra commented Mar 6, 2021

Thanks

@spence-s
Copy link

spence-s commented Mar 6, 2021

In the meantime - I forked and published simple-pug-loader - if anyone was having similar problems as me with this loader.

@christopherdowson
Copy link
Member

christopherdowson commented Mar 13, 2021 via email

@bloodyowl
Copy link

Likewise, not in this org anymore.

@noahbrenner
Copy link

@alexander-akait From the recent comments, it looks like @sokra was given repo permission a week or so ago, so he might be the one to coordinate with.

@sokra
Copy link
Collaborator

sokra commented Mar 15, 2021

I only have write access. I can't move or give anyone else access.

@noahbrenner
Copy link

@sokra Ah, that makes sense. In case it's helpful for tracking someone down to make the change, here's a way you can look up who's an admin: https://stackoverflow.com/questions/42538330/find-out-who-is-the-admins-for-a-git-repo/42539102

I did this with another repo earlier today, and it worked to just pass the endpoint to $ gh api. That way, you don't have to manually pass an access token.

@sokra
Copy link
Collaborator

sokra commented Mar 15, 2021

Ok here are the admins:

          {
              "login": "hemanth",
              "name": "hemanth.hm"
          },
          {
              "login": "tjconcept",
              "name": "Thomas Jensen"
          },
          {
              "login": "ForbesLindesay",
              "name": "Forbes Lindesay"
          },
          {
              "login": "TimothyGu",
              "name": "Timothy Gu"
          },
          {
              "login": "jbnicolai",
              "name": "Joshua Appelman"
          },

@noahbrenner
Copy link

Hi, pug-loader repo admins! @hemanth @tjconcept @ForbesLindesay @TimothyGu @jbnicolai

What do you think of alexander-akait's and sokra's offer of the webpack team supporting pug-loader and moving it to webpack-contrib?

There have been some issues unaddressed for a while, particularly changing the version range of the pug dependency to support the newest version. It sounds like the webpack folks would love to take that maintenance work off your hands.


@tjconcept:

I've added @sokra as an admin.

It's looking like you've added him with write privileges, but not as an admin. Would you be up for giving him admin access? Does there need to be more discussion between current admins first?

@sokra
Copy link
Collaborator

sokra commented Mar 22, 2021

Note that even with admin access I will only move this repo if there is an official "go" from the maintainers.

@tjconcept
Copy link
Member

I won't move it as I never got such mandate from the author.

I think the suggestion for the webpack team to maintain it is great, if it's valuable to them. I see no reason they can't go ahead with that.

@ForbesLindesay
Copy link
Member

ForbesLindesay commented Oct 1, 2021

I'm happy to move this package to webpack-contrib. I don't (unfortunately) have permission to create a repo in that org, so cannot do it right now. I'm also happy to add someone from the webpack team to the npm package.

Please e-mail me ([email protected]) when you've given me permission to create repos in webpack-contrib. I'm also happy for any of the other maintainers to go ahead and move it if that's easier.

P.S. sorry for the delayed response. I've been very focused on other projects this year, and had un-watched this repo as I don't personally use pug & webpack together on any projects and there were several other maintainers listed.

@alexander-akait
Copy link

@ForbesLindesay Done https://github.com/webpack-contrib/pug-loader and assigned you to admin

@oliversalzburg
Copy link

I see the new repo is still not available yet. I wanted to open some issues and was wondering what the right place would be to work on this project.

@alexander-akait
Copy link

@ForbesLindesay Friendly ping

@m10
Copy link

m10 commented Oct 27, 2021

Please e-mail me ([email protected]) when you've given me permission to create repos in webpack-contrib.

did someone send him an e-mail? He probably won't receive / read notifications since he unwatched the repo etc?

@noahbrenner
Copy link

@alexander-akait Did you try emailing him? As m10 pointed out, it sounds like he doesn't have notifications enabled for this repo and instead asked you to email after setting up the necessary permissions.

@alexander-akait
Copy link

@noahbrenner yes, multiple times

@Rush
Copy link

Rush commented Nov 23, 2021

In case anybody is looking for a good alternative, I started using https://github.com/webdiscus/pug-loader (I am not affiliated!) which has great Webpack 5 support and reloading on every dependant file. And it even has multiple rendering modes. html mode is very useful for Angular. I just migrated my server-build templates and Angular app templates to this new loader and everything went fast and smooth.

@m10
Copy link

m10 commented Feb 11, 2022

any update on this? is there some other way you can proceed with this? @ForbesLindesay seems unavailable..?
has someone else the necessary rights to move this repo (now that there is an "ok" from the author)?
Is it a possible alternative to use https://github.com/webdiscus/pug-loader as a basis instead?
@tjconcept @sokra @alexander-akait

@alexander-akait
Copy link

Looks like https://github.com/webdiscus/pug-loader is good solution

@Rush
Copy link

Rush commented Feb 11, 2022

Looks like https://github.com/webdiscus/pug-loader is good solution

Correct. The latest version of webdiscus/pug-loader 1.7.1 even works well with webpack asset pipeline. I can require icon assets directly from PUG and it will resolve proper locations.

@webdiscus
Copy link

webdiscus commented Apr 22, 2022

Hello,

I have released new version v2.2.0 of the pug-plugin. This plugin already contains the @webdiscus/pug-loader.

Why the pug-plugin?

  • you can define pug template as webpack entry-point
const PugPlugin = require('pug-plugin');
module.exports = {
  entry: {
    'index': './src/template/index.pug',
    'about': './src/template/pages/about/index.pug',
    // ...
  },
  plugins: [
    new PugPlugin(),
  ],
  module: {
    rules: [
      {
        test: /\.pug$/,
        loader: PugPlugin.loader,
      },
    ],
  },
  // ...
};
  • source files of scss, js can be used directly in pug, do not need to define them in the webpack entry
    all required resources in pug will be automatically processed by webpack
link(href=require('./styles.scss') rel='stylesheet')
script(src=require('./main.js'))
  • generated HTML contains hashed CSS and JS output filenames
<link href="/assets/css/styles.05e4dd86.css" rel="stylesheet">
<script src="/assets/js/main.f4b855d8.js"></script>
  • resolves source files in SCSS/CSS and replace them with hashed output filenames
// resolve assets in imported package
@use 'material-icons'; 

// resolve webpack alias
@font-face {
  font-family: 'Montserrat';
  src: url('~Fonts/Montserrat/Montserrat-Regular.woff2'); //-> url(/assets/fonts/Montserrat-Regular.woff2)
}

// resolve relative path
.header {
  background-image: url('../images/header.png'); //-> url(/assets/img/header.4fe56ae8.png)
}
  • pug-plugn can pretty format HTML
    the pretty option of original pug-loader is deprecated and not works

  • test coverage 99% with many usage cases

You can see complete example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests