Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for env vars at startup #196

Closed
gabestein opened this issue Dec 7, 2023 · 0 comments · Fixed by #230
Closed

Check for env vars at startup #196

gabestein opened this issue Dec 7, 2023 · 0 comments · Fixed by #230
Assignees
Labels

Comments

@gabestein
Copy link
Member

gabestein commented Dec 7, 2023

Motivation

So the app fails fast if it hasn't been configured properly, rather than appearing to run and then failing as it's used.

Requirements

  • When the core app starts, it should check that every required environment variable exists before anything else happens.
  • Converts existing process.env callsites to checking a module
    - Disallow using process.env

Acceptance Criteria

  • Executes before everything else, to avoid race conditions/false positives/etc.
  • Checks both front-end and back-end environment variables separately, to avoid next errors
  • Adds a new module that parses process.env and exports an object with the app's parsed configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants