Subscribe / presence stateless methods #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add stateless methods for subscribe / presence API.
Fix arguments which is passed to `SubscribeRouter` in `receiveMessages`.
Add flag which will allow to enable beta version of subscribe loop.
parfeon
added
priority: medium
kleewho
reviewed
Feb 8, 2022
| @@ -33,7 +33,7 @@ public class SubscriptionSession { | |||
|
|
|||
| public let uuid = UUID() | |||
| let longPollingSession: SessionReplaceable | |||
| internal(set) var configuration: SubscriptionConfiguration | |||
| var configuration: SubscriptionConfiguration | |||
There was a problem hiding this comment.
@kleewho this one changed in master already.
Swift SDK already have |
|
@parfeon I'm just trying to close out PRs that I'm attached to. Is this PR still valid? |
|
Yep. This one still valid. Waiting when there will be decision to make release. |
|
This has been done in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: subscribe / presence stateless methods
Add stateless methods for subscribe / presence API.