Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Disconnecting typing does not appear to work #178

Open
WalrusSoup opened this issue Aug 27, 2024 · 3 comments
Open

Bug: Disconnecting typing does not appear to work #178

WalrusSoup opened this issue Aug 27, 2024 · 3 comments

Comments

@WalrusSoup
Copy link
Contributor

WalrusSoup commented Aug 27, 2024

Disconnecting from typing listeners via the function returned from getTyping does not appear to work. The old CB will still receive events.

// Stop watching the old channel
if (this.currentChannelStopTypingUpdatesDisconnectFunction) {
    console.log('disconnecting existing handler')
    this.currentChannelStopTypingUpdatesDisconnectFunction();
}
// Watch only the new channel
this.currentChannelStopTypingUpdatesDisconnectFunction = channel.getTyping((typing) => {
    console.log('got typing events');
});

To reproduce:

  1. Join the same channel
  2. Have the user start typing
  3. Call disconnect
  4. Callback still keeps firing
@piotr-suwala
Copy link
Contributor

Hello!

We've put your item in the backlog and we'll take care of this in near future :)

@WalrusSoup
Copy link
Contributor Author

Any update on this?

@piotr-suwala
Copy link
Contributor

Hey @WalrusSoup!

typing.mov

I just tried to recreate the issue and failed. It seems to work for me. See the video attached.
I pushed a commit with the example here: 853c109#diff-82a02fd2c96af79012636f51cae5376725b1a0753a894e7ba7eaaf07bff78a6dR223

Could you try to recreate the issue using our React Native Group Chat example above, please? You can modify my changes.

Besr
Piotr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants