Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubNub memory leak detected #169

Open
vzhurintulaco opened this issue Jun 8, 2023 · 0 comments
Open

PubNub memory leak detected #169

vzhurintulaco opened this issue Jun 8, 2023 · 0 comments

Comments

@vzhurintulaco
Copy link

vzhurintulaco commented Jun 8, 2023

The cause of memory leak is public class TelemetryManager : IDisposable.
This class is created by public class Pubnub is case of config.EnableTelemetry == true but will never be disposed.
It can lead to significantly increasing of Number of Active Timers and ultimately lead to memory leak.
image

Also, non-disposed timers can affect monitor tools (e.g. New Relic) -
image

My suggestion is:

  1. Add IDisposable interface to Pubnub class.
  2. Implement Dispose method to clear this.TelemetryManager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant