-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect critical interfaces (/capture, /capture/v2, /upload, /spectrums/0000) with system tests #673
Comments
could you guide me to this? |
I think the tests for As a result, other pages could be looked into before like Since things like uploading and going to the specific spectrum would require logging in to the app. We could test from simply going to the webpage...then logging in the app with some admin account...Capturing the spectra and saving the data at /spectrums/0000 The upload test could be carried out similarly, difference being that the image could be uploaded instead of captured which would also require user login. @jywarren, thoughts ? |
Hi @unnati914 🙌 if you would like to contribute you might want to first install the software on your local machine and take a look at how plots2 tests are written - https://github.com/publiclab/plots2/tree/main/test/system. This might give you some idea how system tests work... |
Hi thank you so much for the help :) |
CC: @jywarren |
Even I had thought of implementing this only 😄 |
|
#660 introduced a new page - let's protect it with some system tests:
https://github.com/publiclab/spectral-workbench/tree/main/test/system
what can we brainstorm that we should test for?
We can similarly improve our confidence and speed merging other things if we protect other critical systems with system tests.
The text was updated successfully, but these errors were encountered: