Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deliver_now to deliver_later #9308

Closed
5 tasks
SidharthBansal opened this issue Mar 15, 2021 · 19 comments · Fixed by #9461
Closed
5 tasks

Change deliver_now to deliver_later #9308

SidharthBansal opened this issue Mar 15, 2021 · 19 comments · Fixed by #9461
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. outreachy

Comments

@SidharthBansal
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝

We should change deliver_now to deliver_later in:

https://github.com/publiclab/plots2/blob/a23a3f98a1847a4d6b7f241299a98dfa877d66ee/app/controllers/user_sessions_controller.rb

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@SidharthBansal SidharthBansal added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 15, 2021
@SidharthBansal
Copy link
Member Author

Part of #6126

@kyleecodes
Copy link

I'll be happy to solve this issue! We are just changing the name -- correct?

@manishaag7
Copy link
Contributor

I would like to solve this issue. I am new to open source and I have applied to outreachy program.

@Yogita98
Copy link

Is anyone of you @manishaag7 and @kyleecodes working on this issue?

@manishaag7
Copy link
Contributor

I am not.. @Yogita98

@Yogita98
Copy link

Alright then since @kyleecodes is not replying I will take up this issue.

@anirudhprabhakaran3
Copy link
Member

anirudhprabhakaran3 commented Mar 29, 2021

@Yogita98 what is your status? Have you made any progress?

@Yogita98
Copy link

@anirudhprabhakaran3 feel free to pick it up if you like

@anirudhprabhakaran3
Copy link
Member

@cesswairimu @SidharthBansal can I work on this issue even if I'm interested in applying for GSoC instead of Outreachy?

@TildaDares
Copy link
Member

I'm an outreachy applicant. Can I take up this issue?

@jywarren
Copy link
Member

Hi it looks like @Yogita98 is all right with @anirudhprabhakaran3 taking this one over. I'll note this in #9083 and also add @Yogita98 to the list of people looking for a first-timers-only issue, if that's right? Thanks all and @TildaDares i'll be sure to find one for you asap. 🎉

@cesswairimu
Copy link
Collaborator

cesswairimu commented Apr 3, 2021

Hi @Yogita98, @anirudhprabhakaran3 accidentally solved another issue instead of this...I could assign this to you if you are still interested....do let me know. thanks

@harryobas
Copy link
Contributor

@cesswairimu Is anyone working on this issue right now? Would be happy to work on this if its still up for grabs

@cesswairimu
Copy link
Collaborator

hi @harryobas, no, you can go ahead and work on it. Thanks

@anirudhprabhakaran3
Copy link
Member

Hey @cesswairimu, have the new tests been merged too? So that when @harryobas makes a fresh fork, he won't get the test errors

@cesswairimu
Copy link
Collaborator

hey @anirudhprabhakaran3 yeah, I merged your pull request . Thanks

@harryobas
Copy link
Contributor

Hi @cesswairimu I have tried to open a pull request after working on this but get failing tests. I'm i missing something?

@cesswairimu
Copy link
Collaborator

@harryobas looks like the tests are failing on all recent PRs, I've opened an issue #9462 and am looking into it. thanks

@elenapiov
Copy link

Hi! I am an Outreachy applicant and I have never contributed to open source before. Can I work on this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. outreachy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants