Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-space indentation from line 2 - 6 on _flags.html.erb #10962

Closed
5 tasks
on2onyekachi opened this issue Apr 6, 2022 · 24 comments
Closed
5 tasks

Double-space indentation from line 2 - 6 on _flags.html.erb #10962

on2onyekachi opened this issue Apr 6, 2022 · 24 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@on2onyekachi
Copy link

on2onyekachi commented Apr 6, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file flags.html.erbin the $plot2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

<script>
-$(document).ready(function () {
-	var table = table_main("#flag_table");
-	$("#all").click(function () { //select all button
-		select_all();
- });
-  var pageselect_val = localStorage.getItem('page-select') || '';
-  $("#pageselect").val(pageselect_val);
-	$("#batch-spam").bind('click', function (e) { //batch spam
-		batch_nav("batch_spam");
-	});
-	$("#batch-publish").bind('click', function (e) { //batch publish
-		batch_nav("batch_publish");
-	});
-	$("#batch-ban").bind('click', function (e) { //batch ban
-		batch_nav("batch_ban");
-	});
-	$("#batch-unban").bind('click', function (e) { //batch ban
-		batch_nav("batch_unban");
-	});
-	$("#delete-batch").bind('click', function (e) { // batch delete
-		batch_nav("batch_delete");
-	});
-	$('#pageselect').change(function () {
-		pagination("#pageselect", "/spam2/flags/filter/");
-	});
-	$('#spammed').on('click', function () { //spam filter
-		search_table("spammed", "/spam2/flags/filter/");
-	});
-	$('#unmoderated').on('click', function () { // unmoderated filter
-		search_table("unmoderated", "/spam2/flags/filter/");
-	});
-	$('#page').on('click', function () { // page filter
-		search_table("page", "/spam2/flags/filter/");
-	});
-	$('#note').on('click', function () { // note filter
-		search_table("note", "/spam2/flags/filter/");
-	});
-	$('#reset').on('click', function () { // all filter
-		search_table("all", "/spam2/flags/filter/");
-	});
-});
<script>
+  $(document).ready(function () {
+    var table = table_main("#flag_table");
+    $("#all").click(function () { //select all button
+      select_all();
+    });
+    var pageselect_val = localStorage.getItem('page-select') || '';
+    $("#pageselect").val(pageselect_val);
+    $("#batch-spam").bind('click', function (e) { //batch spam
+      batch_nav("batch_spam");
+    });
+    $("#batch-publish").bind('click', function (e) { //batch publish
+      batch_nav("batch_publish");
+    });
+    $("#batch-ban").bind('click', function (e) { //batch ban
+      batch_nav("batch_ban");
+    });
+    $("#batch-unban").bind('click', function (e) { //batch ban
+      batch_nav("batch_unban");
+    });
+    $("#delete-batch").bind('click', function (e) { // batch delete
+      batch_nav("batch_delete");
+    });
+    $('#pageselect').change(function () {
+      pagination("#pageselect", "/spam2/flags/filter/");
+    });
+    $('#spammed').on('click', function () { //spam filter
+      search_table("spammed", "/spam2/flags/filter/");
+    });
+    $('#unmoderated').on('click', function () { // unmoderated filter
+      search_table("unmoderated", "/spam2/flags/filter/");
+    });
+    $('#page').on('click', function () { // page filter
+      search_table("page", "/spam2/flags/filter/");
+    });
+    $('#note').on('click', function () { // note filter
+      search_table("note", "/spam2/flags/filter/");
+    });
+    $('#reset').on('click', function () { // all filter
+      search_table("all", "/spam2/flags/filter/");
+    });
+  });
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@on2onyekachi on2onyekachi added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Apr 6, 2022
@welcome
Copy link

welcome bot commented Apr 6, 2022

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@on2onyekachi on2onyekachi changed the title Update indentation from line 2 - 6 on _flags.html.erb Double-space indentation from line 2 - 6 on _flags.html.erb Apr 6, 2022
@TildaDares
Copy link
Member

Perfect @on2onyekachi!!!

@TildaDares
Copy link
Member

Reserved for @Dapper50 for 24 hours!!

@TildaDares TildaDares added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Apr 6, 2022
@on2onyekachi
Copy link
Author

Perfect @on2onyekachi!!!

Thank you, would it be best to break the rest indentations into different issues or create an issue of a lengthy indentation?

@TildaDares
Copy link
Member

It’d be better to do everything in one PR so that there are no merge conflicts.

@on2onyekachi
Copy link
Author

Yeah true. Okay,

should I update this to include the rest indentation?

@TildaDares
Copy link
Member

Yeah you can update this issue.

@on2onyekachi
Copy link
Author

Okay, done. much better

@Dapper50
Copy link
Contributor

Dapper50 commented Apr 6, 2022

@TildaDares please assist review

@tushmahe
Copy link

tushmahe commented Apr 6, 2022

Can I work on this issue? @TildaDares

@tushmahe
Copy link

tushmahe commented Apr 6, 2022

@TildaDares I have made changes, awaiting your review.

@Dapper50
Copy link
Contributor

Dapper50 commented Apr 6, 2022

@tushmahe the issue was reserved for me to work on, which I already have and was awaiting a feedback.

@tushmahe
Copy link

tushmahe commented Apr 7, 2022

@Dapper50 Okay! I am extremely sorry for interruption!

@Dapper50
Copy link
Contributor

Dapper50 commented Apr 7, 2022

@tushmahe it is fine, I would reach out to you if I need help concerning the project or any other task. Please feel free to do same 🤗

1 similar comment
@Dapper50
Copy link
Contributor

Dapper50 commented Apr 7, 2022

@tushmahe it is fine, I would reach out to you if I need help concerning the project or any other task. Please feel free to do same 🤗

@on2onyekachi
Copy link
Author

@tushmahe you can request for FTO at #10153 if you haven't done so.

@tushmahe
Copy link

tushmahe commented Apr 7, 2022

@Dapper50 Yeah Sure!!

@tushmahe
Copy link

tushmahe commented Apr 7, 2022

@on2onyekachi Okay and Thanks for guiding me !!

@abdelquodr
Copy link

is this issue done already?

@on2onyekachi
Copy link
Author

You're welcome @tushmahe . While you wait to be assigned an issue.

You can go through the project wherever you find an issue or a bug to fix, you can as well create it for yourself and also try to create some for others too.

@on2onyekachi
Copy link
Author

is this issue done already?

Yes.

@abdelquodr
Copy link

ok. Can anyone assign a new issue for me

@Bhawna-Sharma-9903
Copy link

This issue is yet open, can i work on this?

@TildaDares
Copy link
Member

Resolved in #10966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

No branches or pull requests

6 participants