Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker component unimplemented #202

Open
eugbash opened this issue Jun 26, 2018 · 3 comments
Open

Picker component unimplemented #202

eugbash opened this issue Jun 26, 2018 · 3 comments
Labels

Comments

@eugbash
Copy link

eugbash commented Jun 26, 2018

It would be great to have the Picker component on macos that renders the native picker component (https://facebook.github.io/react-native/docs/picker.html).
Do you have any plans to implement this?

@ptmt
Copy link
Owner

ptmt commented Jul 3, 2018

Do you mean https://developer.apple.com/documentation/appkit/nscombobox? As far as I know, I tried to implement it before, need to investigate if it's available.

@eugbash
Copy link
Author

eugbash commented Jul 4, 2018

Exactly.
Yes, I found it at /Libraries/Picker/PickerIOS.macos.js
I was confused as the render method in /Libraries/Components/Picker/Picker.js returned <UnimplementedView />.

Updating its condition to
if (Platform.OS === 'ios' || Platform.OS === 'macos') {
// $FlowFixMe found when converting React.createClass to ES6
return <PickerIOS {...this.props}>{this.props.children}</PickerIOS>;
}
fixed the issue.

However, NSComboBox seems to render not quite right (please, see the image below).
nscombobox

@ptmt
Copy link
Owner

ptmt commented Jul 7, 2018

Thanks for your feedback!
If you had time to send PR with this (even unfinished) that would be extremely helpful, I'll try to see what's happening with the rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants