Skip to content

Commit 4bc14da

Browse files
committed
Updates documentation on dynamic item classes.
Fixes scrapy#398
1 parent 283d6a5 commit 4bc14da

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

docs/topics/practices.rst

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@ classes instead of manually coding them.
199199
from scrapy.item import DictItem, Field
200200

201201
def create_item_class(class_name, field_list):
202-
field_dict = {}
203-
for field_name in field_list:
204-
field_dict[field_name] = Field()
202+
fields = {field_name: Field() for field_name in field_list}
205203

206-
return type(class_name, (DictItem,), field_dict)
204+
return type(class_name, (DictItem,), {'fields': fields})

0 commit comments

Comments
 (0)