-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to pkg-config to find out the information about libpq #1001
Comments
Patch? |
AFAICS pkg-config only deals with the system package. On my ubuntu laptop I have PG 11 installed but libpq.pg declares to be PG 12 (it belongs to the libpq-dev package). I don't think this can be used. |
this is not true. pkg-config support is there since pg 8 or so. in doubt you need to set PKG_CONFIG_PATH to find the .pc files for your local installation. pg_config is not meant for client bindings. So I would kindly ask to reopen this bug. |
I can keep it open as a feature request but I'm not keen to dedicate personal time to this change. |
pkg-config would also save some pain for building on macOS with homebrew openssl I have but that was no dice here. I had to set an explicit
to get psycopg2 to build when everything else has been able to find it |
Does |
#1315 shows how less maintainable a pkg-config solution is compared to pg_config. |
In addition, elimanate unnecessary dependency (development package for PostgreSQL). This helps to avoid issues on some new disctibutions like openSUSE 15.3 that misses the pg_config utility necessary to install psycopg2 from sources (psycopg/psycopg2#1001). Probably there will be some performance degradation, but it is not crucial for our use cases.
pg_config was meant for building server extensions.
The text was updated successfully, but these errors were encountered: