Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove namespace_packages=['ZPsycopgDA'], from setup.py #2

Open
dwt opened this issue Oct 28, 2014 · 4 comments
Open

remove namespace_packages=['ZPsycopgDA'], from setup.py #2

dwt opened this issue Oct 28, 2014 · 4 comments

Comments

@dwt
Copy link
Contributor

dwt commented Oct 28, 2014

The package isn't a namespace package, and this greatly hinders installation as both pip install ZPsycopgDA as well as easy install ZPsycopgDA both fail.

The offending line: https://github.com/psycopg/ZPsycopgDA/blob/master/setup.py#L48

@dvarrazzo
Copy link
Member

Is removing that line enough to solve the problem?

@dwt
Copy link
Contributor Author

dwt commented Oct 29, 2014

I am pretty sure, since the package isn't actually a namespace package, as it is doing stuff in it's __init__.py.

@jdnier
Copy link

jdnier commented May 18, 2016

I will verify that removing the line is the correct solution (Zope 2.13 and Python 2.7). I just had to remove that line myself to get installation via easy_install and pip to work, where before installation was failing with the error

# pip install ZPsycopgDA
Downloading/unpacking ZPsycopgDA
  Downloading ZPsycopgDA-2.4.6.zip
  Running setup.py (path:/tmp/pip_build_root/ZPsycopgDA/setup.py) egg_info for package ZPsycopgDA

    error: Namespace package problem: ZPsycopgDA is a namespace package, but its
    __init__.py does not call declare_namespace()! Please fix it.
    (See the setuptools manual under "Namespace Packages" for details.)

This patch isn't available in the version released on PyPI (2.4.6 from 2013-03-16, which is currently 16 commits behind master).

@icemac
Copy link

icemac commented Jan 8, 2019

As #3 is merged this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants