Merge post print status during merge

[ajkiessl]

When merging an Activity Insight publication into a Pure publication we lose the post print status for a period of time before the next AI import. We should merge post print statuses into the record to keep during merge. Since this will be important for all types of merges, it should be implemented somewhere in the Publication#merge method. We'll have to determine what to do when we have multiple Activity Insight publications with differing post print statuses.

[anaelizabethenriquez]

@ajkiessl I'm wondering if we should prioritize this to get the AI OA workflow working well, or if it's unrelated.

[ajkiessl]

@anaelizabethenriquez This won't affect anything in the AI OA Workflow. The only place the Activity Insight Post Print status is being used is in the OA notification emails filter. We exclude users' publications who have this status as "In Progress".

I guess we might want to consider using these statuses to filter things out of the AI OA Workflow, or prevent certain files from being imported at all if they're "Already Openly Available" or "Deposited to ScholarSphere". That should be a separate issue, though.

[EricDurante]

I guess we might want to consider using these statuses to filter things out of the AI OA Workflow, or prevent certain files from being imported at all if they're "Already Openly Available" or "Deposited to ScholarSphere". That should be a separate issue, though.

My gut says not. We're already checking what are probably more reliable sources of this information (including going straight to the source for what's already in ScholarSphere). In any case, I don't think I'd do this preemptively unless/until we can prove a need for it.

[anaelizabethenriquez]

Could this be related to #1005

[ajkiessl]

WDDLL

When merging publications, post print statuses should be merged. We'll need to come up with a ranking for the statuses, kind of like how PreferredOpenAccessPolicy ranks sources. The post print statuses are:

'Already Openly Available',
'Cannot Deposit',
'Deposited to ScholarSphere',
'File provided was not a post-print',
'In Progress'

[anaelizabethenriquez]

@ajkiessl As I think about this more, I am not sure how this should work. Can you remind me whether we would ever write the merged status back into Activity Insight? From the Activity Insight side of things, I would not want the postprint status from one Activity Insight user's record for a publication to get written into their coauthor's record for it in Activity Insight. Some of these statuses would not make sense in that context.

However, we should ideally be suppressing all emails about a publication if one Activity Insight user has uploaded a file in Activity Insight. Am I understanding correctly that completing this issue is necessary to accomplish that?

[ajkiessl]

@anaelizabethenriquez We don't send post print statuses over to Activity Insight that have been stored in the RMD database. So, we wouldn't write the merged status back to Activity Insight. When we update the post print status in Activity Insight for a publication, we just send along the new value, but don't update the post print status in RMD. Then, that publication waits for the Activity Insight import to update the post print status in RMD. Exporting the post print status to Activity Insight only targets the publication associated with the file we are storing in RMD, so it shouldn't affect coauthors' records.

However, we should ideally be suppressing all emails about a publication if one Activity Insight user has uploaded a file in Activity Insight. Am I understanding correctly that completing this issue is necessary to accomplish that?

No, this issue isn't necessary to accomplish that. We currently only suppress emails about a publication if it has a post print status of "In Progress". This issue was going to prevent that period of time after merging where the post print status might have gone from "In Progress" to null — opening it up to notifications.

So maybe what we want here is to change the filter to not just filter out publications with an "In Progress" post print status, but all publications that have an associated Activity Insight OA File. Does that sound correct?

Then, if the OA notification filter is no longer dependent on the post print status, merging them probably doesn't matter much anymore. We can just depend on the Activity Insight import to update the post print status.

[anaelizabethenriquez]

@ajkiessl I'm not sure I'm following all of this, but your suggestion to "change the filter to not just filter out publications with an "In Progress" post print status, but all publications that have an associated Activity Insight OA File" sounds OK. The only problem I foresee is that it's currently very rare for us to remove files from the system (things get stuck in Wrong File Version, see #997), so we could end up suppressing too many emails. However, at the moment it's much better to suppress too many than to send ones that we shouldn't, so let's go with that. Can you create the new issue for that and deprioritize this one?

[ajkiessl]

@anaelizabethenriquez Yes, I will do that.