Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send OA Notification emails out for publications with Activity Insight OA Files #1027

Closed
ajkiessl opened this issue Dec 3, 2024 · 1 comment · Fixed by #1035
Closed
Assignees

Comments

@ajkiessl
Copy link
Contributor

ajkiessl commented Dec 3, 2024

In the User#needs_open_access_notification filter, let's remove the activity_insight_postprint_status where clause:

.where('publications.activity_insight_postprint_status IS NULL OR publications.activity_insight_postprint_status != ?', 'In Progress')

And instead, filter out any publication that has an associated Activity Insight OA File.

@anaelizabethenriquez If a user does receive an OA notification email (for a different publication that does not have an Activity Insight OA File) should publications with Activity Insight OA Files be filtered out of the email? We don't currently filter out publications with a post print status of "In Progress" from these emails.

@ajkiessl ajkiessl added this to the Fall-Winter 2024-2025 milestone Dec 3, 2024
@anaelizabethenriquez
Copy link
Collaborator

@ajkiessl Yes! The publications with Activity Insight OA Files should be filtered out of the email text (in addition to not triggering an email). This probably explains most/all of what I noticed in #1005.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants