-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescue and log Net::ReadTimeout
when sending oa email notifications
#1018
Comments
We may also want to consider moving the time when these emails go out. Seems to be more common that there are network issues Sunday night. We had these emails going out Monday mornings before infrastructure changes. |
related to #959 (timing issue) |
We also might want to look in to how large the email is that fails. It could be that there's a user with a lot of publications listed, and there's an email that times out because it takes a while to send. |
Interesting. If so, that would be another reason (besides usability) to address #735. |
In case anecdotal evidence is helpful, I checked the date on a recent reminder email sent to a very prolific researcher (4279). They typically get very long emails, so I wondered if it would have led to a time-out. However, their latest email went out November 3, when a full batch sent. Since they replied to it, I can tell you that it mentioned 8 new publications and 32 previous ones. Maybe something other than the size of the email is causing the time-out? |
|
I ran the notification task in QA and it did not raise any errors. Waiting to see if the rescue code catches anything in production. |
In
OpenAccessNotifier#send_notification_to_user
, we rescueNet::SMTPFatalError
and log it so the iterator continues to the next notification. We have, however, run into otherNet
errors. Specifically:ReadTimeout
. This could be caused by a temporary issue with the connection to the mail server, so I think it makes sense to rescue it as well, log it, and move to the next notification.The text was updated successfully, but these errors were encountered: