Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve string comparisons #45

Closed
petri opened this issue Apr 18, 2020 · 1 comment
Closed

improve string comparisons #45

petri opened this issue Apr 18, 2020 · 1 comment
Milestone

Comments

@petri
Copy link
Collaborator

petri commented Apr 18, 2020

The current implementation just does case-insensitive matching. Comparisons are however much more complex in Unicode world. See for example:

https://stackoverflow.com/questions/319426/how-do-i-do-a-case-insensitive-string-comparison

http://www.unicode.org/reports/tr15/#Normalization_Forms_Table

@petri petri mentioned this issue Apr 18, 2020
@petri petri linked a pull request Apr 18, 2020 that will close this issue
@psolin psolin added this to the Version 2.0 milestone Apr 19, 2020
@petri
Copy link
Collaborator Author

petri commented Apr 21, 2020

Done in 708e1ae

@petri petri closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants