Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

country logic does not work for terms ending with '.' #40

Closed
murphd40 opened this issue Sep 9, 2019 · 2 comments
Closed

country logic does not work for terms ending with '.' #40

murphd40 opened this issue Sep 9, 2019 · 2 comments
Milestone

Comments

@murphd40
Copy link

murphd40 commented Sep 9, 2019

business_name = "Some Big Pharma sh.a."
x = cleanco(business_name)

print(x.business_name)
print(x.string_stripper(x.business_name))
print(x.clean_name())
print(x.country())

prints:

Some Big Pharma sh.a.
Some Big Pharma sh.a
Some Big Pharma
None

sh.a. is in the Albania terms:

'Albania': ['sh.a.', 'sh.p.k.'],

It is not being recognized as Albanian because the . at the end of sh.a. is removed in:

business_name = self.string_stripper(business_name)

@byrro
Copy link

byrro commented Sep 13, 2019

@psolin are you reviewing/accepting pull requests? I could take a look at this and other issues to contribute if it's welcome.

@psolin
Copy link
Owner

psolin commented Sep 21, 2019

Yes, absolutely. I need to spend more time cleaning this up for sure.

@psolin psolin added this to the Version 2.0 milestone Apr 19, 2020
@psolin psolin linked a pull request Apr 19, 2020 that will close this issue
@psolin psolin closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants