Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions are always false #51

Open
qarkai opened this issue Jul 24, 2017 · 0 comments
Open

Expressions are always false #51

qarkai opened this issue Jul 24, 2017 · 0 comments

Comments

@qarkai
Copy link

qarkai commented Jul 24, 2017 •
edited
Loading

There are several comparisons iris/src/irisnet/noncore/cutestuff/socks.cpp which are always false.
https://github.com/psi-im/iris/blob/master/src/irisnet/noncore/cutestuff/socks.cpp#L639 since sps_get_version() returns 0 or 1.
https://github.com/psi-im/iris/blob/master/src/irisnet/noncore/cutestuff/socks.cpp#L689 since sps_get_authUsername() returns 0 or 1.
https://github.com/psi-im/iris/blob/master/src/irisnet/noncore/cutestuff/socks.cpp#L713 and https://github.com/psi-im/iris/blob/master/src/irisnet/noncore/cutestuff/socks.cpp#L878 since sp_get_request() returns 0 or 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qarkai