You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent PR I made to PSL, lowered the type coverage from 100% to 99%, and I didn't notice until after it got merged and I saw the badge. while the fix was pretty easy ( 00602d71 ), I would have rather the CI failed in the PR or at least shepherd bot commented to alert about the type coverage decrease.
The text was updated successfully, but these errors were encountered:
azjezz
changed the title
[Feature Request] report PR that bring down type coverage
[Feature Request] report PRs that bring down type coverage
Aug 3, 2020
I like the idea of a coverage threshold which would fail builds if Psalm coverage was below the threshold... something like vendor/bin/psalm --coverage --coverageThreshold=100... but that seems like more of a job for Psalm than for the Shepherd package. 🤷
A recent PR I made to PSL, lowered the type coverage from 100% to 99%, and I didn't notice until after it got merged and I saw the badge. while the fix was pretty easy ( 00602d71 ), I would have rather the CI failed in the PR or at least shepherd bot commented to alert about the type coverage decrease.
The text was updated successfully, but these errors were encountered: