-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to choose which PHP version to use #48
Comments
I'm thinking of tackling this issue with the following solution:
@muglug @weirdan Does this specification make sense to you, or do you have any remarks? |
I must say I really like PHPStan implementation: https://phpstan.org/r/13d9f782-9b40-4013-bc34-8177c6f5857b Every version is checked so when there are differences, the versions appear clearly. It even help users understand issues on their own when they see they aren't running the correct version |
It will also need to be a part of slug calculation, so that snippets differing in version only have different urls. |
I think saving this info in the DB makes sense. @orklah I don’t think the PHPStan way is really necessary — users rarely ticket issues where the version of PHP is decisive for the bug/feature. |
Today I learn that psalm.dev has support for different PHP version via query parameter - vimeo/psalm#5442 (comment)
So It would be really helpfull for users if there was an clear choice to choose used PHP version on the UI itself.
The text was updated successfully, but these errors were encountered: