Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Heroku hosting is being phased out #658

Closed
weirdan opened this issue Aug 25, 2022 · 12 comments
Closed

Free Heroku hosting is being phased out #658

weirdan opened this issue Aug 25, 2022 · 12 comments

Comments

@weirdan
Copy link
Member

weirdan commented Aug 25, 2022

Got this today:

Dear Customer,

Thank you for being a Heroku user. Starting November 28, 2022, free Heroku Dynos, free Heroku Postgres, and free Heroku Data for Redis® will no longer be available. You can learn more about these and other important changes from our GM, Bob Wise, on the Heroku blog.

Existing free dynos and Heroku data add-ons will be impacted, so action by you is required. To prevent any disruption to your apps or data using free plans, you will need to upgrade from a free plan to a paid plan before November 28, 2022.

For instructions on how to upgrade and for other questions, please visit our FAQ.

Thank you,

The Heroku Team

@weirdan
Copy link
Member Author

weirdan commented Aug 25, 2022

Currently it serves ~30 requests per day.

@weirdan
Copy link
Member Author

weirdan commented Aug 25, 2022

So it's probably quite affordable to go serverless in this case.

@weirdan
Copy link
Member Author

weirdan commented Oct 1, 2022

Got it running on Google Cloud functions: #6 (comment)

@weirdan
Copy link
Member Author

weirdan commented Oct 2, 2022

The Google Cloud function deployment and hosting work fine.

@weirdan
Copy link
Member Author

weirdan commented Oct 2, 2022

@orklah @muglug there's a new github application available: https://github.com/apps/psalm-github-bot-beta, currently installed in this repo only, in addition to the regular bot. We should test it and then replace update the primary bot settings with to use the function running on GCF.

@weirdan
Copy link
Member Author

weirdan commented Oct 2, 2022

This comment should be picked up by both bots.

https://psalm.dev/r/4121eceef8

@ghost
Copy link

ghost commented Oct 2, 2022

I found these snippets:

https://psalm.dev/r/4121eceef8
<?php

/**
 * @return array<string>
 */
function takesAnInt(int $i) {
    return [$i, "hello"];
}

$data = ["some text", 5];
takesAnInt($data[0]);

$condition = rand(0, 5);
if ($condition) {
} elseif ($condition) {}
Psalm output (using commit 028ac7f):

ERROR: InvalidReturnStatement - 7:12 - The inferred type 'array{int, 'hello'}' does not match the declared return type 'array<array-key, string>' for takesAnInt

ERROR: InvalidReturnType - 4:12 - The declared return type 'array<array-key, string>' for takesAnInt is incorrect, got 'array{int, 'hello'}'

ERROR: InvalidScalarArgument - 11:12 - Argument 1 of takesAnInt expects int, 'some text' provided

ERROR: TypeDoesNotContainType - 15:11 - Operand of type 0 is always falsy

ERROR: TypeDoesNotContainType - 15:11 - Type 0 for $condition is always !falsy

1 similar comment
@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/4121eceef8
<?php

/**
 * @return array<string>
 */
function takesAnInt(int $i) {
    return [$i, "hello"];
}

$data = ["some text", 5];
takesAnInt($data[0]);

$condition = rand(0, 5);
if ($condition) {
} elseif ($condition) {}
Psalm output (using commit 028ac7f):

ERROR: InvalidReturnStatement - 7:12 - The inferred type 'array{int, 'hello'}' does not match the declared return type 'array<array-key, string>' for takesAnInt

ERROR: InvalidReturnType - 4:12 - The declared return type 'array<array-key, string>' for takesAnInt is incorrect, got 'array{int, 'hello'}'

ERROR: InvalidScalarArgument - 11:12 - Argument 1 of takesAnInt expects int, 'some text' provided

ERROR: TypeDoesNotContainType - 15:11 - Operand of type 0 is always falsy

ERROR: TypeDoesNotContainType - 15:11 - Type 0 for $condition is always !falsy

@orklah
Copy link

orklah commented Oct 2, 2022

seems to work fine! What should we do to install it?

@weirdan
Copy link
Member Author

weirdan commented Oct 2, 2022

  1. There's no rush, the Heroku-hosted bot should work fine until Nov 28.
  2. I think when the time comes I would just replace github app settings for the current bot with the settings for the new one, so no reinstallation would be necessary. However, if I'm not available at that time you could just uninstall the old one and install the new one:

@weirdan
Copy link
Member Author

weirdan commented Oct 2, 2022

Installation in vimeo/psalm repo may require admin access, so you may need to contact @muglug

@weirdan
Copy link
Member Author

weirdan commented Nov 19, 2022

@psalm-github-bot (production version) now runs on GCF.

@orklah you don't need to install beta bot, nor you can as I deleted it.

@weirdan weirdan closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants