Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unecessary handling for duplicate packets. #25

Open
ps2 opened this issue Sep 16, 2015 · 3 comments
Open

Avoid unecessary handling for duplicate packets. #25

ps2 opened this issue Sep 16, 2015 · 3 comments

Comments

@ps2
Copy link
Owner

ps2 commented Sep 16, 2015

A simple "is this the same packet as the last one we handled, and if so, drop it" should cut down on most of the duplicates.

@loudnate
Copy link
Collaborator

Yeah, that's what I'm doing, though equality is defined as lhs.pumpDate == rhs.pumpDate && lhs.glucoseDate == rhs.glucoseDate since the sequence numbers will differ.

@ps2
Copy link
Owner Author

ps2 commented Aug 7, 2016

Same logic is done in both Loop and RileyLink. Though I would like to record what the actual MySentry does, as I remember it had a way of ACKing that avoided subsequent packets being sent from the pump.

@loudnate
Copy link
Collaborator

loudnate commented Aug 8, 2016

The original problem with my attempts to ACK was not replying with the sequence number. You figured that out during refactoring of the sentry pairing, so maybe we should try again.

I'd love to get that 10s back every 5 minutes to ease my phone's battery usage.

ps2 added a commit that referenced this issue Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants