Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prysm v5.2.0 seems not compatible with ristretto v0.1.2 #14751

Open
simonzg opened this issue Dec 26, 2024 · 1 comment
Open

Prysm v5.2.0 seems not compatible with ristretto v0.1.2 #14751

simonzg opened this issue Dec 26, 2024 · 1 comment

Comments

@simonzg
Copy link

simonzg commented Dec 26, 2024

💎 Issue

I'm using prysm v5.2.0 and one of my dependencies requires github.com/dgraph-io/ristretto v0.1.2, but failed to compile:

# github.com/prysmaticlabs/prysm/v5/beacon-chain/db/kv
../../../go/pkg/mod/github.com/prysmaticlabs/prysm/[email protected]/beacon-chain/db/kv/kv.go:89:23: cannot use generic type ristretto.Cache[K z.Key, V any] without instantiation
../../../go/pkg/mod/github.com/prysmaticlabs/prysm/[email protected]/beacon-chain/db/kv/kv.go:90:23: cannot use generic type ristretto.Cache[K z.Key, V any] without instantiation
../../../go/pkg/mod/github.com/prysmaticlabs/prysm/[email protected]/beacon-chain/db/kv/kv.go:158:41: cannot use generic type ristretto.Config[K z.Key, V any] without instantiation
../../../go/pkg/mod/github.com/prysmaticlabs/prysm/[email protected]/beacon-chain/db/kv/kv.go:167:45: cannot use generic type ristretto.Config[K z.Key, V any] without instantiation
make: *** [supernova] Error 1

it doesn't help if I downgrade prysm to v5.1.x

Background

Description

The prysm is using ristretto v0.0.4, is this dependency upgradeable?

@nisdas
Copy link
Member

nisdas commented Dec 26, 2024

Hey @simonzg , thanks for flagging this. We would be open to a PR upgrading the version to the latest stable one along with the respective code changes required to make the updated version functional in prysm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants