fix: blob sidecar validation to ensure KZG commitment count matches #14752
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR adds validation to ensure that the number of available blob sidecars matches the number of KZG commitments in the block before responding to BlobSidecarsByRange requests. This prevents Prysm nodes from serving an incorrect number of blob sidecars that don't match the block's KZG commitment count.
The changes include:
This fix ensures compliance with the P2P specification rule that states: "Clients MUST include all blob sidecars of each block from which they include blob sidecars."
Which issues(s) does this PR fix?
Fixes #14674
Other notes for review
The implementation adds minimal overhead as it only performs counting operations on existing data structures. The error handling follows existing patterns in the codebase.
Acknowledgements