From 4fce10796462fadcb4d37702358fb591cc3bf840 Mon Sep 17 00:00:00 2001
From: ChangHyunLee <dlckdgus200011@gmail.com>
Date: Tue, 4 Mar 2025 12:38:18 +0900
Subject: [PATCH] fix(nhn): replace sys.exit with exceptions for token
 retrieval errors

---
 prowler/providers/nhn/nhn_provider.py    |  5 ++---
 tests/providers/nhn/nhn_provider_test.py | 14 +++++++-------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/prowler/providers/nhn/nhn_provider.py b/prowler/providers/nhn/nhn_provider.py
index a5376a9f43..ae4185ed6b 100644
--- a/prowler/providers/nhn/nhn_provider.py
+++ b/prowler/providers/nhn/nhn_provider.py
@@ -1,4 +1,3 @@
-import sys
 from typing import Optional
 
 import requests
@@ -209,10 +208,10 @@ def setup_session(self) -> None:
                 logger.critical(
                     f"Failed to get token. Status: {response.status_code}, Body: {response.text}"
                 )
-                sys.exit(1)
+                raise ValueError("Failed to get NHN token")
         except Exception as e:
             logger.critical(f"[setup_session] Error: {e}")
-            sys.exit(1)
+            raise e
 
     @staticmethod
     def test_connection(
diff --git a/tests/providers/nhn/nhn_provider_test.py b/tests/providers/nhn/nhn_provider_test.py
index c929208b16..0f5a174721 100644
--- a/tests/providers/nhn/nhn_provider_test.py
+++ b/tests/providers/nhn/nhn_provider_test.py
@@ -62,14 +62,14 @@ def test_nhn_provider_init_token_fail(self, mock_post, mock_load_config):
         mock_post.return_value.status_code = 401
         mock_post.return_value.text = "Unauthorized"
 
-        provider = NhnProvider(
-            username="test_user",
-            password="test_pass",
-            tenant_id="tenant123",
-        )
+        with pytest.raises(ValueError) as exc_info:
+            NhnProvider(
+                username="test_user",
+                password="test_pass",
+                tenant_id="tenant123",
+            )
 
-        assert provider._token is None
-        assert provider.session is None
+        assert "Failed to get NHN token" in str(exc_info.value)
 
     @patch("prowler.providers.nhn.nhn_provider.requests")
     def test_test_connection_success(self, mock_requests):