Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sqlite with Sqlalchemy #75

Open
scientes opened this issue Sep 9, 2021 · 6 comments
Open

Replace sqlite with Sqlalchemy #75

scientes opened this issue Sep 9, 2021 · 6 comments
Labels
idea Something for the distant future

Comments

@scientes
Copy link
Contributor

scientes commented Sep 9, 2021

This allows us database agnostic SQL programming and enables us to Support multiple SQL flavors out of the Box (sqlite, MySQL,postgresql are the ones i know that are defintively supported)

@provinzio
Copy link
Owner

I think that this is overkill and only adds another dependency.

@scientes
Copy link
Contributor Author

scientes commented Sep 12, 2021

could we make it optional?
like: if sqlalchemy is not found use sqlite
this would need that we make a database class for all operations (_get_price_db etc) which we could switch depending on if sqlalchemy is installed or not:

try: 
    import sqlalchemy
    database=alchemyDB(path)
except ImportError:
    import sqllite3
    database=sqliteDB(path)

i'd someday like to make a small web app out of this and for that an actual db server would be nice, so i do not have the hassle of making sqlite concurrent

but WAL could be a fix for that

@provinzio
Copy link
Owner

A wrapper for sqlalchemy is definitely an over-overkill. If it's important for you, we can change to sqlalchemy, but this issue should be our lowest priority.

@scientes
Copy link
Contributor Author

Or we i could just make a wrapper for mysql/postgresql and we don't have the Overkill anymore

@scientes
Copy link
Contributor Author

But yes this is far future for me

@provinzio
Copy link
Owner

Or we i could just make a wrapper for mysql/postgresql and we don't have the Overkill anymore

Sqlalchemy is exactly what you use in that case

@provinzio provinzio added the idea Something for the distant future label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Something for the distant future
Projects
None yet
Development

No branches or pull requests

2 participants