Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airdrop #115

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Airdrop #115

wants to merge 3 commits into from

Conversation

Griffsano
Copy link
Contributor

@Griffsano Griffsano commented Mar 26, 2022 •
edited
Loading

Closes #104, #132

To-do list

  • Change documentation in readme
  • Read-in configuration files to define if airdrops are taxable
  • Match airdrops to configurations from files
  • Change default taxation of airdrops to taxable (if no entry is found in the configuration files)
  • Implement taxation of taxable airdrops (both buy and sell behavior)

provinzio
provinzio reviewed Mar 26, 2022
View reviewed changes
src/transaction.py
@@ -108,7 +108,10 @@ class StakingInterest(Transaction):


class Airdrop(Transaction):
pass
taxable = True
Copy link
Owner

@provinzio provinzio Mar 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value needs to be defined in init. If you define it here. It's a general class variable. Alle classes share this variable / or define it as taxable: bool = True without type annotation it's a class wide variable.

https://stackoverflow.com/questions/61937520/proper-way-to-create-class-variable-in-data-class

@Griffsano Griffsano mentioned this pull request Mar 29, 2022
Closed
7 tasks
@provinzio provinzio mentioned this pull request May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzio provinzio provinzio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Germany: Taxation of Airdrops
2 participants
@Griffsano @provinzio