PHP Extension - Inconsistent final modifier for Google\Protobuf\Timestamp

[FabioBatSilva]

In PHP C extension implementation of Google\Protobuf\Timestamp is marked as final but not in the native PHP implementation.

This creates inconsistency between the two:

PHP Implementation :

protobuf/php/src/Google/Protobuf/Timestamp.php

Line 82 in e3ac4c9

class Timestamp extends \Google\Protobuf\Internal\TimestampBase

C Implementation

protobuf/php/ext/google/protobuf/wkt.inc

Line 1616 in e3ac4c9

google_protobuf_Timestamp_ce->ce_flags |= ZEND_ACC_FINAL;

[JasonLunn]

Thanks for reporting this issue, @FabioBatSilva.

Same kind of question as in #20036 - Is this issue unique to the Timestamp class, or does it impact other well known types?

[FabioBatSilva]

This is the only one I ran into, but there are likely more.

final modifier on the ext :
https://github.com/search?q=repo%3Aprotocolbuffers%2Fprotobuf++ZEND_ACC_FINAL+path%3Aphp%2Fext&type=code

final modifiers on php (none):
https://github.com/search?q=repo%3Aprotocolbuffers%2Fprotobuf+final+language%3Aphp+path%3Aphp%2Fsrc%2FGoogle%2FProtobuf&type=code

[JasonLunn]

Do you have the bandwidth to send a PR to address this?

[FabioBatSilva]

Yes, I think..
I've been meaning to do so..

I have a branch with patches for the issues I found :
ChessCom/protobuf@main...ChessCom:protobuf:protobuf-4.30-debug

Need split it up and clean up a few things before I send PRs.

[JasonLunn]

To clarify - once split up, would those PR's cover any of your other open issues?

[FabioBatSilva]

I think It covers #20000, #20036, #19978, #20041

But the expected behavior is not clear in some of them.
I just patched it enough to allow us to continue testing the extension.